Revert "Lint all files all the time"

This reverts commit e1ae94a.

Reason for revert: Increases `git cl upload` time to 3+ minutes if the cache is cold.

Original change's description:
> Lint all files all the time
>
> We should lint all files in the repo to ensure that we don't get
> sideeffect errors coming from EsLint TypeScript or our rules that
> user Type information.
>
> We will pay a small price locally of around ~10 sec, compare to
> the previous approach of running it only for specific files.
>
> Bug: 480874485
> Change-Id: I87b6760975516aea257572a0d3d25ac7d154c4ba
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7531350
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Liviu Rau <liviurau@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 480874485
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: If3f3090b33d99c8895ad3100f4f958e1fa35ce56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7543693
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Author: szuend

PRESUBMIT.py

@@ -109,6 +109,7 @@ def _CheckWithNodeScript(input_api,
                          output_api,
                          script_path,
                          script_arguments=None,
+                         allow_typescript=False,
                          message=None):
     original_sys_path = sys.path
     try:
@@ -128,6 +129,23 @@ def _CheckWithNodeScript(input_api,
                               message=message)
 
 
+def _GetFilesToLint(input_api, lint_config_files, accepted_endings):
+    run_full_check = False
+    files_to_lint = []
+
+    # We are changing the lint configuration; run the full check.
+    if len(lint_config_files) != 0:
+        run_full_check = True
+    else:
+        root_dir = input_api.os_path.join(input_api.PresubmitLocalPath())
+        # Only run the linter on files that are relevant, to save PRESUBMIT time.
+        files_to_lint = _GetAffectedFiles(input_api, root_dir, ['D'],
+                                          accepted_endings)
+
+    should_bail_out = len(files_to_lint) == 0 and not run_full_check
+    return should_bail_out, files_to_lint
+
+
 def _CheckFormat(input_api, output_api):
     if _IsEnvCog(input_api):
         return [
@@ -194,7 +212,6 @@ def CheckDevToolsLint(input_api, output_api):
                                        'scripts', 'test', 'run_lint_check.mjs')
 
     lint_related_paths = [
-        lint_path,
         input_api.os_path.join(input_api.PresubmitLocalPath(),
                                'eslint.config.mjs'),
         input_api.os_path.join(input_api.PresubmitLocalPath(),
@@ -204,30 +221,34 @@ def CheckDevToolsLint(input_api, output_api):
         # This file includes the LitAnalyzer rules
         input_api.os_path.join(input_api.PresubmitLocalPath(), 'front_end',
                                'tsconfig.json'),
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts',
+                               'test', 'run_lint_check.mjs'),
         input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules'),
     ]
 
     lint_config_files = _GetAffectedFiles(input_api, lint_related_paths, [],
                                           [])
-    root_dir = input_api.os_path.join(input_api.PresubmitLocalPath())
-    lintable_files_changed = _GetAffectedFiles(input_api, root_dir, ['D'],
-                                               ['.css', '.mjs', '.js', '.ts'])
-
-    should_bail_out = len(lintable_files_changed) == 0 and len(
-        lint_config_files) == 0
 
+    should_bail_out, files_to_lint = _GetFilesToLint(
+        input_api, lint_config_files, ['.css', '.mjs', '.js', '.ts'])
     if should_bail_out:
         # Run the formatter on all non-js like files
         results = []
         results.extend(_CheckFormat(input_api, output_api))
         return results
 
+    # If there are more than 50 files to check, don't bother and check
+    # everything, so as to not run into command line length limits on Windows.
+    if len(files_to_lint) > 50:
+        files_to_lint = []
+
     results = []
     results.extend(
         _CheckWithNodeScript(input_api,
                              output_api,
                              lint_path,
-                             script_arguments=[],
+                             script_arguments=files_to_lint,
+                             allow_typescript=True,
                              message="Lint"))
 
     results.extend(_CheckFormat(input_api, output_api))

scripts/test/run_lint_check.mjs

@@ -352,9 +352,7 @@ async function run() {
     }
   }
 
-  const frontEndFiles = scripts.filter(
-    script => script.includes('front_end') && !script.endsWith('.test.ts'),
-  );
+  const frontEndFiles = scripts.filter(script => script.includes('front_end'));
   const esLintRules = scripts.filter(script =>
     script.includes('scripts/eslint_rules')
   );