Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nodejs_version: auto in DDEV and standardize on .node-version file instead #226

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

apotek
Copy link
Contributor

@apotek apotek commented Dec 4, 2024

This change makes sure we use the now-standard .node-version file to set the node version, since DDEV now reads that file if nodejs_version is set to auto.

Resolves #225

@apotek apotek requested a review from agarzola December 4, 2024 20:25
@apotek apotek self-assigned this Dec 4, 2024
@apotek apotek requested review from mattdaniel and mmatsoo December 8, 2024 02:35
Copy link
Member

@mmatsoo mmatsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@apotek apotek merged commit 132a091 into 5.x Dec 9, 2024
5 checks passed
@apotek apotek deleted the 225-use-node-version branch December 9, 2024 15:51
@apotek
Copy link
Contributor Author

apotek commented Dec 9, 2024

Thank you @mmatsoo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use .node-version file to specify node version
2 participants