[MicroWin] Fix %TEMP% path lookup

[CodingWonders]

Type of Change

• New feature
• Bug fix
• Documentation update
• Hotfix
• UI/UX improvement

Description

Apparently special characters in the user path cause %TEMP% to go to the older, crappier, DOS style (8.3). More here: https://devblogs.microsoft.com/oldnewthing/20041224-00/?p=36893.

Anyway, this should be fixed now.

NOTE THAT YOU MAY SEE ADDITIONAL FILES THAT HAVE NOTHING TO DO WITH MICROWIN. This is normal because indentation produced by changes hasn't been normalized to spaces. Simply ignore.

I mark it as a draft because I have to test it.

Issue related to PR

• Resolves ISO creation failure #3970

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.

[agadiffe]

according to the linked issue, the error occured in line 139:

if ($importDrivers) {
    Write-Host "Exporting drivers from active installation..."
    if (Test-Path "$env:TEMP\DRV_EXPORT") {
        Remove-Item "$env:TEMP\DRV_EXPORT" -Recurse -Force
    }

In Invoke-Microwin.ps1:
There is 7 mentions of $env:TEMP between 139 and 161.
4 more between 292 and 306.
And the one you fixed line 562.

In Invoke-MicrowinGetIso.ps1:
You missed:
$fidopath, line 61 & 67.
and also line 90 & 149,

ctrl+f is your friend :)

[CodingWonders]

Weird... I thought I had replaced all the occurrences. I did use CTRL+F, maybe it was a filter

[agadiffe]

some update:
not all cmdlet are affected, but as a good measure, I would not use $env:TEMP at all. (as you did)
e.g. Test-Path is not affected.
I made a new comment here: #3970 (comment)