Generic Search Function for finding parties of deals

[NikolasHaimerl]

Implementing a Generic Search Function

Description

Currently, our codebase contains specialized search functions like findDealActors and findDealClients. This creates duplication and increases the complexity of our codebase.

Proposal

Replace these specialized functions with a more generic search function, such as findPartyDeal. This would:

1. Simplify the codebase
2. Reduce code duplication
3. Provide more flexibility

Example implementation:

const findPartyDeal = (retrievalTasks, minerId, cid, partyName) => {
  const deal = retrievalTasks.find(t => t.cid === cid && t.minerId === minerId);
  
  return deal ? deal[partyName] : undefined;
}

References

Original discussion from PR comments between @pyropy and @bajtos.

[bajtos]

I am a mild -1 on this proposal.

we'd need to change input data and have the search function actually search trought the input data rather than returning predefined array on specific miner id.

I would find such tests more difficult to understand and work with. That's why I created the findDealClients abstraction.