From 2a40e58a4e94d65def8683504605b63aeddf4dde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Tue, 11 Mar 2025 12:41:02 +0100 Subject: [PATCH 1/2] feat: require Spark Checker version >=1.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have recently introduced a new requirement - when an HTTP retrieval succeeded, the checker is required to test HEAD retrieval request too. The preprocessing step in spark-evaluate discards measurements missing `head_status_code`. Because a large part of the network is running an older version of Spark Checker, measurements from these nodes are rejected as invalid. See https://github.com/CheckerNetwork/spark-evaluate/pull/498. This patch is moving the validation step earlier to the pipeline by changing the minimum required Spark Checker version to 1.17.0. Checker nodes running an older version will start receiving a helpful "OUTDATED CLIENT" error response. Signed-off-by: Miroslav Bajtoš --- api/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/index.js b/api/index.js index 77119ca6..4960279f 100644 --- a/api/index.js +++ b/api/index.js @@ -59,7 +59,7 @@ const createMeasurement = async (req, res, client) => { validate(measurement, 'sparkVersion', { type: 'string', required: false }) validate(measurement, 'zinniaVersion', { type: 'string', required: false }) assert( - typeof measurement.sparkVersion === 'string' && satisfies(measurement.sparkVersion, '>=1.13.0'), + typeof measurement.sparkVersion === 'string' && satisfies(measurement.sparkVersion, '>=1.17.0'), 410, 'OUTDATED CLIENT' ) From 03797f30e8b2130f0a419b3f7123264243283470 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Tue, 11 Mar 2025 13:22:41 +0100 Subject: [PATCH 2/2] fixup! update the spark version used by tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miroslav Bajtoš --- api/test/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/test/test.js b/api/test/test.js index f120c697..0e7e7c3c 100644 --- a/api/test/test.js +++ b/api/test/test.js @@ -14,7 +14,7 @@ import { createTelemetryRecorderStub } from '../../test-helpers/platform-test-he const { DATABASE_URL } = process.env const participantAddress = '0x000000000000000000000000000000000000dEaD' -const sparkVersion = '1.13.0' // This must be in sync with the minimum supported client version +const sparkVersion = '1.17.0' // This must be in sync with the minimum supported client version const currentSparkRoundNumber = 42n const VALID_DEAL_INGESTION_TOKEN = 'authorized-token'