-
Notifications
You must be signed in to change notification settings - Fork 1
Spark score for retrievals using any available provider #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would we really want to check all providers or check them until we receive payload from at least one of them? On other subnets we randomly check one node for the given blob id / transaction hash. I don't think that it would be fair toward them if we check ALL providers serving this retrieval. I propose that we pick one random node from the IPNI lookup response (excluding the SP node we have probed before that) and try to perform retrieval on that node. cc @bajtos |
SGTM. We can start with what you proposed and then iteratively improve the solution later as needed. It would be great if we could find a simple heuristic for preferring a Filecoin retrieval provider. (IPFS nodes can advertise to IPNI, too, I am concerned about how many of them actually serve retrievals.) Here are some ideas:
|
That sounds great to me! I only wonder if we should more stats about this measurement or keep it simple and just include measurements status (status code or boolean status)? I think it would be okay to go with the latter and add in more fields later in a backwards compatible way. |
I agree to keep it simple. I prefer a new status code (one number) over a boolean status; it will give us much more information for troubleshooting at a minimal overhead. We should also add information about which retrieval provider we picked up. That information will be important for troubleshooting, too. You can reports the provider peer id, similarly to how we are reporting |
@bajtos We're evaluating retrieval on few fields: In this case we won't evaluate network wide measurement success status by Do you think that it would be an overkill to include all these fields? |
I don't have a strong opinion. If we need this fields to capture the retrieval check result, then we must include them. I think it would be nice to refactor the checker to signal If you decide to make such a change, then please open a standalone set of pull requests for that. Remember that we must support both flavours ( |
Uh oh!
There was an error while loading. Please reload this page.
In https://space-meridian.slack.com/archives/C06RPCL6QGL/p1742802306479569, we discussed how different storage DePINs address the availability of retrievals.
This difference makes it difficult to compare retrievability scores for different storage networks.
Let's add a new Spark score that measures how many deals (CIDs) can be retrieved from the network using any available retrieval provider, including non-Filecoin nodes running IPFS.
Notes:
NO_VALID_ADVERTISEMENT
, we want to try to retrieve the payload CId from all providers found in the IPNI lookup response. (Potentially de-duplicating entries from the same provider but with different protocols.)The text was updated successfully, but these errors were encountered: