Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars doesn't work for non-English cl.Step name #1555

Open
AbdulrahmanAlGhofaily opened this issue Dec 1, 2024 · 2 comments
Open

Avatars doesn't work for non-English cl.Step name #1555

AbdulrahmanAlGhofaily opened this issue Dec 1, 2024 · 2 comments
Labels
bug Something isn't working frontend Pertains to the frontend.

Comments

@AbdulrahmanAlGhofaily
Copy link

Bug description
Avatars doesn't work for languages that doesn't use English letters. I've tried to use cl.Step with the name="اسم عربي" an Arabic name. Chainlit will attempt to access the image with the same name as cl.Step name (اسم عربي.png). First it will encode it to "%D8%A7%D8%B3%D9%85+%D8%B9%D8%B1%D8%A8%D9%8A" then it will try to access the file with same previous encoded name which cause it to fail and throw an error in the console.
(Tried to set the avatar name to "اسم عربي.png" and the encoded name.png, both didn't work)

Steps to reproduce the behavior:

  1. Set cl.Step name parameter to any non-English name (Using non-English letters).
  2. Run the application and send a message.
  3. Open browser console and check the error message there.

Expected behavior
The avatar image will not show up, an error in the console indicates that the source image doesn't exist.

Screenshots
image

@dosubot dosubot bot added bug Something isn't working frontend Pertains to the frontend. labels Dec 1, 2024
@dokterbob
Copy link
Collaborator

Thanks for the feedback.

This is a known problem and we're working on it. Basically, we should sanitise (e.g. turn into URL-safe ASCII) avatar URL's client-side.

What's pending: #1420 (comment)

I'm open to you forking by PR to implement my proposal there. Otherwise, I expect to get to it some time in the coming week.

@willydouhard
Copy link
Collaborator

Would love to get that fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Pertains to the frontend.
Projects
None yet
Development

No branches or pull requests

3 participants