Skip to content

polkadot-launch is broken in CI caused by a conflict check added in #107 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clearloop opened this issue Jun 17, 2021 · 4 comments · Fixed by #129
Closed

polkadot-launch is broken in CI caused by a conflict check added in #107 #127

clearloop opened this issue Jun 17, 2021 · 4 comments · Fixed by #129
Labels
e2e Integration testing needs triage Issue needs to be triaged

Comments

@clearloop
Copy link
Contributor

Issue summary

PINT/node/src/cli.rs

Lines 57 to 66 in a8f1972

#[structopt(long)]
pub parachain_id: Option<u32>,
/// Write output in binary. Default is to write in hex.
#[structopt(short, long)]
pub raw: bool,
/// The name of the chain for that the genesis state should be exported.
#[structopt(long, conflicts_with = "parachain-id")]
pub chain: Option<String>,

Modify the /config.json

  • or pr polkadot-launch
  • or remove the conflict check
@clearloop clearloop added needs triage Issue needs to be triaged e2e Integration testing labels Jun 17, 2021
@clearloop
Copy link
Contributor Author

https://github.com/paritytech/polkadot-launch/blob/2844f6534741dca6f6563e4b2ce69964c5d3ffd1/src/spawn.ts#L118

Both --parachain-id and --chain are required in polkadot-launch now

@clearloop clearloop changed the title polkadot-launch are broken in CI because a new conflict check added in #107 polkadot-launch is broken in CI caused by a conflict check added in #107 Jun 17, 2021
@clearloop
Copy link
Contributor Author

@mattsse
Copy link
Contributor

mattsse commented Jun 17, 2021

I see,
interestingly the template uses conflicts_with https://github.com/substrate-developer-hub/substrate-parachain-template/blob/master/node/src/cli.rs#L62

Yes this restriction doesn't make a lot of sense, simply removing the attributes will fix this.
Do you want to take this on?

@clearloop
Copy link
Contributor Author

Do you want to take this on?

Sure, #123 requires this to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Integration testing needs triage Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants