Skip to content

Commit e85b6e1

Browse files
authored
Rollup merge of rust-lang#60169 - varkor:tidy-unnecessary-ignore-newline, r=kennytm
Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
2 parents 3bcf011 + 5ab5806 commit e85b6e1

114 files changed

Lines changed: 182 additions & 250 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/ci/docker/dist-various-1/install-x86_64-redox.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#!/usr/bin/env bash
2-
# ignore-tidy-linelength
32

43
set -ex
54

src/ci/docker/dist-various-2/build-fuchsia-toolchain.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#!/usr/bin/env bash
22

3-
# ignore-tidy-linelength
4-
53
set -ex
64
source shared.sh
75

src/test/codegen-units/item-collection/cross-crate-closures.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// ignoring this test until MIR codegen has taken over completely
44
// ignore-test
55

6-
// ignore-tidy-linelength
76
// compile-flags:-Zprint-mono-items=eager
87

98
#![deny(dead_code)]

src/test/codegen-units/item-collection/cross-crate-generic-functions.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/cross-crate-trait-method.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/function-as-argument.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/generic-functions.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/generic-impl.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/impl-in-non-instantiated-generic.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

src/test/codegen-units/item-collection/items-within-generic-items.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// ignore-tidy-linelength
21
// compile-flags:-Zprint-mono-items=eager
32

43
#![deny(dead_code)]

0 commit comments

Comments
 (0)