Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider sanity checks on TransactionBuilder bch/token total #239

Open
mr-zwets opened this issue Nov 7, 2024 · 0 comments
Open

consider sanity checks on TransactionBuilder bch/token total #239

mr-zwets opened this issue Nov 7, 2024 · 0 comments
Labels
javascript-sdk Relates to the CashScript JavaScript SDK

Comments

@mr-zwets
Copy link
Member

mr-zwets commented Nov 7, 2024

Unlike the simple transaction builder in transaction.ts the 'advanced transaction builder' does not do any safety/sanity checks in the total bch amount in in- and outputs, the tokenamount in in- and outputs and the NFTs involved in the transaction.

It might be good if on .build() and .send() it would do some sanity checks to catch errors early (mocknet testing won't catch these errors otherwise I think)

@mr-zwets mr-zwets added the javascript-sdk Relates to the CashScript JavaScript SDK label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript-sdk Relates to the CashScript JavaScript SDK
Projects
None yet
Development

No branches or pull requests

1 participant