-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time slider doesn't show value of numeric columns only date types #200
Comments
In order to populate the timeslider with any values other than the corresponding step number, the layergroup needs to return the start / end values, so for this to happen we'd have to modify it from Windshaft, right @rochoa ? |
What do you mean by start/end values? The tiler already returns start and end time, check this example: https://rochoa.cartodb.com/api/v1/map/named/tpl_9d99e242_5f9a_11e4_bc5f_0e853d047bba/jsonp?callback=cb |
Yeah but I mean, for non-date fields. 2000-2010 are numerical values, for which we don't provide start/end in the layergroup right? |
It never worked like that but since we have the start end values we could interpolate in the same way we do with timestamps. we need to be careful with this change since it changes the way time slider works for already working maps |
I seee, apologies, I was under the impression that we only returned start/end for datetypes. This makes it much more visible. Cool! |
Take a look,
https://team.cartodb.com/u/andrew/tables/andrew.all_month_delete/public/map
The column used as my date column is a numeric one ranging from 2000-2010. You can see it in the table view as 'yoy'.
The expected behavior would be that the slider column would show 2000-2010, instead it shows the animation step which doesn't make much sense.
The text was updated successfully, but these errors were encountered: