🐛 Remove value as an input

Author: bal7hazar

src/interfaces/minter.cairo

@@ -58,9 +58,7 @@ namespace ICarbonableMinter {
     func getMigrationValue() -> (value: Uint256) {
     }
 
-    func initializeMigration(
-        source_address: felt, target_address: felt, slot: Uint256, value: Uint256
-    ) {
+    func initializeMigration(source_address: felt, target_address: felt, slot: Uint256) {
     }
 
     func migrate(tokenId: Uint256) -> (newTokenId: Uint256) {

src/mint/minter.cairo

@@ -206,9 +206,10 @@ func getMigrationValue{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_che
 // @param value The target value to mint.
 @external
 func initializeMigration{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
-    source_address: felt, target_address: felt, slot: Uint256, value: Uint256
+    source_address: felt, target_address: felt, slot: Uint256
 ) {
     Ownable.assert_only_owner();
+    let (value) = getUnitPrice();
     Migrator.initializer(source_address, target_address, slot, value);
     CarbonableInitializer.initialize(MIGRATION);
     return ();

tests/integrations/protocol/library.cairo

@@ -252,7 +252,7 @@ func setup{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}() {
     admin_instance.vester_transfer_ownership(carbonable_yielder);
 
     // Set up migrator
-    admin_instance.initialize_migration(carbonable_project, carbonable_3525_address, 1, 100);
+    admin_instance.initialize_migration(carbonable_project, carbonable_3525_address, 1);
 
     return ();
 }

tests/integrations/protocol/libs/admin.cairo

@@ -814,18 +814,16 @@ namespace instance {
     }
 
     func initialize_migration{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
-        source_address: felt, target_address: felt, slot: felt, value: felt
+        source_address: felt, target_address: felt, slot: felt
     ) {
         let slot_u256 = Uint256(low=slot, high=0);
-        let value_u256 = Uint256(low=value, high=0);
         let (carbonable_minter) = carbonable_minter_instance.get_address();
         let (caller) = get_address();
         with carbonable_minter {
             carbonable_minter_instance.initialize_migration(
                 source_address=source_address,
                 target_address=target_address,
                 slot=slot_u256,
-                value=value_u256,
                 caller=caller,
             );
         }

tests/integrations/protocol/libs/anyone.cairo

@@ -665,18 +665,16 @@ namespace instance {
     }
 
     func initialize_migration{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}(
-        source_address: felt, target_address: felt, slot: felt, value: felt
+        source_address: felt, target_address: felt, slot: felt
     ) {
         let slot_u256 = Uint256(low=slot, high=0);
-        let value_u256 = Uint256(low=value, high=0);
         let (carbonable_minter) = carbonable_minter_instance.get_address();
         let (caller) = get_address();
         with carbonable_minter {
             carbonable_minter_instance.initialize_migration(
                 source_address=source_address,
                 target_address=target_address,
                 slot=slot_u256,
-                value=value_u256,
                 caller=caller,
             );
         }

tests/integrations/protocol/libs/minter.cairo

@@ -160,10 +160,10 @@ namespace instance {
 
     func initialize_migration{
         syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr, carbonable_minter: felt
-    }(source_address: felt, target_address: felt, slot: Uint256, value: Uint256, caller: felt) {
+    }(source_address: felt, target_address: felt, slot: Uint256, caller: felt) {
         %{ stop_prank = start_prank(caller_address=ids.caller, target_contract_address=ids.carbonable_minter) %}
         ICarbonableMinter.initializeMigration(
-            carbonable_minter, source_address, target_address, slot, value
+            carbonable_minter, source_address, target_address, slot
         );
         %{ stop_prank() %}
         return ();

tests/integrations/protocol/test_minter.cairo

@@ -221,7 +221,7 @@ func test_initialize_migration_revert_not_owner{
     alloc_locals;
 
     %{ expect_revert("TRANSACTION_FAILED", "Ownable: caller is not the owner") %}
-    anyone.initialize_migration(0, 0, 0, 0);
+    anyone.initialize_migration(0, 0, 0);
 
     return ();
 }