Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle wine-mono and wine-gecko with wine-cachyos/wine-cachyos-opt #491

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

loathingKernel
Copy link
Collaborator

  • wine-cachyos: bundle wine-gecko and wine-mono
  • wine-cachyos-opt: bundle wine-gecko and wine-mono
  • cachyos-gaming-meta: remove wine-gecko and wine-mono, bundled with wine-cachyos
  • cachyos-gaming-meta: replace wine-cachyos with wine-cachyos-opt

@loathingKernel loathingKernel marked this pull request as draft January 24, 2025 13:05
@loathingKernel loathingKernel marked this pull request as ready for review January 24, 2025 14:04
Copy link
Member

@1Naim 1Naim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the skipped pkgrel, LGTM. I think it makes sense that a meta package should use a package that doesn't conflict with another system package (wine). Though I believe to make the transition a bit smoother we should provide a guide in the wiki or so on how to use the wine installed in /opt.

cachyos-gaming-meta/.SRCINFO Outdated Show resolved Hide resolved
cachyos-gaming-meta/PKGBUILD Outdated Show resolved Hide resolved
@loathingKernel
Copy link
Collaborator Author

loathingKernel commented Jan 24, 2025

Though I believe to make the transition a bit smoother we should provide a guide in the wiki or so on how to use the wine installed in /opt.

I agree, although I might not be the right person to do it because I do not daily-drive the various launchers people use. I can update the wiki with generic instructions though to serve as a base example. I do have plans to include an extra wrapper binary to be placed in /usr/bin to invoke wine from /opt.

Though I explained the pkgrel skip I am not particular to it, and if needed for clarity or anything, I can update them to not skip.

@1Naim
Copy link
Member

1Naim commented Jan 24, 2025

I can update the wiki with generic instructions though to serve as a base example.

Yes, that's perfectly fine.

@1Naim
Copy link
Member

1Naim commented Jan 29, 2025

I think this branch has some offtopic commits now. You should branch these off to have them separate from your work branch.

@loathingKernel loathingKernel force-pushed the loathing branch 2 times, most recently from e89453b to ac93d83 Compare January 29, 2025 17:27
@crian
Copy link

crian commented Feb 2, 2025

What is the status of this one? When will it be merged?

@1Naim
Copy link
Member

1Naim commented Feb 4, 2025

Right, are there any blockers for this (except the merge conflict of course, but that's trivial)? I would like to get this merged so we have parity with the wiki.

@loathingKernel
Copy link
Collaborator Author

I have resolved the conflicts. I do not think there is anything outstanding blocking this right now.

@ptr1337 ptr1337 merged commit 72ebfce into master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants