Skip to content

Commit eaecf9c

Browse files
committed
Tweaks to #18
1 parent ee43cb1 commit eaecf9c

File tree

7 files changed

+27
-20
lines changed

7 files changed

+27
-20
lines changed

database/index.js.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// @flow
2-
import type { FirebaseError } from 'firebase';
2+
import typeof { FirebaseError } from 'firebase';
33
import type { DataSnapshot, Query } from 'firebase/database';
44

55
export type ListHook = {

firestore/helpers/index.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { firestore } from 'firebase';
1+
import { firestore, FirebaseError } from 'firebase';
22

33
export const snapshotToData = (
44
snapshot: firestore.DocumentSnapshot,
@@ -10,3 +10,12 @@ export const snapshotToData = (
1010
...(idField ? { [idField]: snapshot.id } : null),
1111
};
1212
};
13+
14+
export const transformError = (error: Error): FirebaseError => {
15+
return {
16+
message: error.message,
17+
stack: error.stack,
18+
name: error.name,
19+
code: '',
20+
};
21+
};

firestore/index.js.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// @flow
2-
import type { FirebaseError } from 'firebase';
2+
import typeof { FirebaseError } from 'firebase';
33
import type {
44
DocumentReference,
55
DocumentSnapshot,

firestore/useCollection.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { firestore, FirebaseError } from 'firebase';
22
import { useEffect } from 'react';
3+
import { transformError } from './helpers';
34
import { useIsEqualRef, useLoadingValue } from '../util';
4-
import { transformError } from '../util/transformError';
55

66
export type CollectionHook = {
77
error?: FirebaseError;
@@ -25,8 +25,12 @@ export default (
2525
return;
2626
}
2727
const listener = options
28-
? ref.current.onSnapshot(options, setValue, (error: Error) => setError(transformError(error)))
29-
: ref.current.onSnapshot(setValue, (error: Error) => setError(transformError(error)));
28+
? ref.current.onSnapshot(options, setValue, (error: Error) =>
29+
setError(transformError(error))
30+
)
31+
: ref.current.onSnapshot(setValue, (error: Error) =>
32+
setError(transformError(error))
33+
);
3034

3135
return () => {
3236
listener();

firestore/useDocument.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { firestore, FirebaseError } from 'firebase';
22
import { useEffect } from 'react';
3+
import { transformError } from './helpers';
34
import { useIsEqualRef, useLoadingValue } from '../util';
4-
import { transformError } from '../util/transformError';
55

66
export type DocumentHook = {
77
error?: FirebaseError;
@@ -25,8 +25,12 @@ export default (
2525
return;
2626
}
2727
const listener = options
28-
? ref.current.onSnapshot(options, setValue, (error: Error) => setError(transformError(error)))
29-
: ref.current.onSnapshot(setValue, (error: Error) => setError(transformError(error)));
28+
? ref.current.onSnapshot(options, setValue, (error: Error) =>
29+
setError(transformError(error))
30+
)
31+
: ref.current.onSnapshot(setValue, (error: Error) =>
32+
setError(transformError(error))
33+
);
3034

3135
return () => {
3236
listener();

storage/index.js.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// @flow
2-
import type { FirebaseError } from 'firebase';
2+
import typeof { FirebaseError } from 'firebase';
33
import type { Reference } from 'firebase/storage';
44

55
export type DownloadURLHook = {

util/transformError.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)