fix: typing errors

Author: jlahovnik

eodag/config.py

@@ -933,14 +933,22 @@ def build_mapping_from_env(
             # try converting env_value type from type hints
             if "list" in str(env_type):
                 # convert str to array and then cast (only working for list[str] type)
-                env_value = env_value.split(",")
-            try:
-                env_value = cast_scalar_value(env_value, env_type)
-            except TypeError:
-                logger.warning(
-                    f"Could not convert {parts[0]} value {env_value} to {env_type}"
-                )
-            mapping[parts[0]] = env_value
+                env_value_list = env_value.split(",")
+                try:
+                    env_value_list = cast_scalar_value(env_value_list, env_type)
+                except TypeError:
+                    logger.warning(
+                        f"Could not convert {parts[0]} value {env_value} to {env_type}"
+                    )
+                mapping[parts[0]] = env_value_list
+            else:
+                try:
+                    env_value = cast_scalar_value(env_value, env_type)
+                except TypeError:
+                    logger.warning(
+                        f"Could not convert {parts[0]} value {env_value} to {env_type}"
+                    )
+                mapping[parts[0]] = env_value
         else:
             new_map = mapping.setdefault(parts[0], {})
             build_mapping_from_env("__".join(parts[1:]), env_value, new_map)

eodag/plugins/manager.py

@@ -278,18 +278,23 @@ def get_download_plugin(self, product: EOProduct) -> Union[Download, Api]:
         if api := getattr(plugin_conf, "api", None):
             plugin_conf.api.products = plugin_conf.products
             plugin_conf.api.priority = plugin_conf.priority
-            plugin = cast(Api, self._build_plugin(product.provider, api, Api))
+            return cast(Api, self._build_plugin(product.provider, api, Api))
         elif getattr(plugin_conf, "download", None):
             plugin = next(
                 self.get_auth_or_download_plugins(
                     "download", product.provider, matching_url=matching_url
                 )
             )
+            if not isinstance(plugin, Download):
+                # basically this should not happen
+                raise MisconfiguredError(
+                    f"Invalid download plugin for provider {plugin_conf.name}"
+                )
+            return plugin
         else:
             raise MisconfiguredError(
                 f"No download plugin configured for provider {plugin_conf.name}."
             )
-        return plugin
 
     def get_auth_plugin(
         self, associated_plugin: PluginTopic, product: Optional[EOProduct] = None
@@ -307,7 +312,7 @@ def get_auth_plugin(
         :returns: The Authentication plugin
         """
         # matching url from product to download
-        matching_url = ""
+        matching_url = None
         if product:
             matching_url = _get_matching_url_for_product(product)
         if not matching_url:
@@ -323,6 +328,11 @@ def get_auth_plugin(
                     matching_conf=associated_plugin.config,
                 )
             )
+            if not isinstance(auth_plugin, Authentication):
+                # basically this should not happen
+                raise MisconfiguredError(
+                    f"Invalid auth plugin found: {auth_plugin.config}"
+                )
         except StopIteration:
             auth_plugin = None
         return auth_plugin
@@ -333,7 +343,7 @@ def get_auth_or_download_plugins(
         provider: str,
         matching_url: Optional[str] = None,
         matching_conf: Optional[PluginConfig] = None,
-    ) -> Iterator[Authentication]:
+    ) -> Iterator[Union[Authentication, Download]]:
         """Build and return the authentication plugin for the given provider and
         matching conf or url
 
@@ -379,18 +389,17 @@ def get_auth_or_download_plugins(
                 ):
                     plugin_conf.priority = provider_conf.priority
                     if plugin_type == "auth":
-                        plugin = cast(
+                        yield cast(
                             Authentication,
                             self._build_plugin(
                                 plugin_provider, plugin_conf, Authentication
                             ),
                         )
                     else:
-                        plugin = cast(
+                        yield cast(
                             Download,
                             self._build_plugin(plugin_provider, plugin_conf, Download),
                         )
-                    yield plugin
                 else:
                     continue
 
@@ -419,7 +428,11 @@ def get_auth(
             ):
                 # not the plugin we were looking for
                 continue
-            if auth_plugin and callable(getattr(auth_plugin, "authenticate", None)):
+            if (
+                auth_plugin
+                and isinstance(auth_plugin, Authentication)
+                and callable(getattr(auth_plugin, "authenticate", None))
+            ):
                 try:
                     auth = auth_plugin.authenticate()
                     return auth