feat: Make arrays linear and add copyable value arrays

Author: mark-koch

hugr-core/src/ops/constant.rs

@@ -605,6 +605,7 @@ pub(crate) mod test {
     use crate::extension::PRELUDE;
     use crate::std_extensions::arithmetic::int_types::ConstInt;
     use crate::std_extensions::collections::array::{array_type, ArrayValue};
+    use crate::std_extensions::collections::value_array::{value_array_type, VArrayValue};
     use crate::{
         builder::{BuildError, DFGBuilder, Dataflow, DataflowHugr},
         extension::{
@@ -778,6 +779,11 @@ pub(crate) mod test {
         ArrayValue::new(bool_t(), [Value::true_val(), Value::false_val()]).into()
     }
 
+    #[fixture]
+    fn const_value_array_bool() -> Value {
+        VArrayValue::new(bool_t(), [Value::true_val(), Value::false_val()]).into()
+    }
+
     #[fixture]
     fn const_array_options() -> Value {
         let some_true = Value::some([Value::true_val()]);
@@ -786,17 +792,35 @@ pub(crate) mod test {
         ArrayValue::new(elem_ty.into(), [some_true, none]).into()
     }
 
+    #[fixture]
+    fn const_value_array_options() -> Value {
+        let some_true = Value::some([Value::true_val()]);
+        let none = Value::none(vec![bool_t()]);
+        let elem_ty = SumType::new_option(vec![bool_t()]);
+        VArrayValue::new(elem_ty.into(), [some_true, none]).into()
+    }
+
     #[rstest]
     #[case(Value::unit(), Type::UNIT, "const:seq:{}")]
     #[case(const_usize(), usize_t(), "const:custom:ConstUsize(")]
     #[case(serialized_float(17.4), float64_type(), "const:custom:json:Object")]
     #[case(const_tuple(), Type::new_tuple(vec![usize_t(), bool_t()]), "const:seq:{")]
     #[case(const_array_bool(), array_type(2, bool_t()), "const:custom:array")]
+    #[case(
+        const_value_array_bool(),
+        value_array_type(2, bool_t()),
+        "const:custom:value_array"
+    )]
     #[case(
         const_array_options(),
         array_type(2, SumType::new_option(vec![bool_t()]).into()),
         "const:custom:array"
     )]
+    #[case(
+        const_value_array_options(),
+        value_array_type(2, SumType::new_option(vec![bool_t()]).into()),
+        "const:custom:value_array"
+    )]
     fn const_type(
         #[case] const_value: Value,
         #[case] expected_type: Type,
@@ -816,7 +840,9 @@ pub(crate) mod test {
     #[case(const_serialized_usize(), const_usize())]
     #[case(const_tuple_serialized(), const_tuple())]
     #[case(const_array_bool(), const_array_bool())]
+    #[case(const_value_array_bool(), const_value_array_bool())]
     #[case(const_array_options(), const_array_options())]
+    #[case(const_value_array_options(), const_value_array_options())]
     // Opaque constants don't get resolved into concrete types when running miri,
     // as the `typetag` machinery is not available.
     #[cfg_attr(miri, ignore)]

hugr-core/src/std_extensions.rs

@@ -21,6 +21,7 @@ pub fn std_reg() -> ExtensionRegistry {
         collections::array::EXTENSION.to_owned(),
         collections::list::EXTENSION.to_owned(),
         collections::static_array::EXTENSION.to_owned(),
+        collections::value_array::EXTENSION.to_owned(),
         logic::EXTENSION.to_owned(),
         ptr::EXTENSION.to_owned(),
     ]);

hugr-core/src/std_extensions/collections.rs

@@ -3,3 +3,4 @@
 pub mod array;
 pub mod list;
 pub mod static_array;
+pub mod value_array;