Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steering_angle_rate_check has a multitude of issues #92

Open
mehulgoel873 opened this issue May 15, 2024 · 0 comments
Open

steering_angle_rate_check has a multitude of issues #92

mehulgoel873 opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mehulgoel873
Copy link
Collaborator

  1. Magic Numbers, why is the threshold 100 deg/second, is this validated (we should comment the math that led to this number)
  2. This steering angle check should be run for both buggies, so the topic name should be better written
  3. Additionally, this logs to a local file, which would be unhelpful overall, and ideally all information should be stored in the bag.
  4. Have a logerr when we pass the treshold as otherwise, no one will check for this flag and its purpose will be lost.
  5. Overall validation should be a stronger suit of robobuggy software
@mehulgoel873 mehulgoel873 added the bug Something isn't working label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant