Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovered tab background color is the same as default state background color #3363

Open
sydk-adhoc opened this issue Dec 27, 2024 · 1 comment

Comments

@sydk-adhoc
Copy link

Background: I have typical deuteranopia, so have some trouble distinguishing subtle color changes, and this is particularly true with things like hover states, when all that changes is text color, and the change is either minor in terms of contrast change or relies on two colors that are problematic for me.

Adding further cues, like a change in background color, can be helpful.

In the case of tabs, it looks to me like there's an intention to change the background color of hovered tabs, but that there's an error in the source tokens (see below), because the two states use exactly the same color (that being #fff, or white). If this isn't a bug, I think the pattern still needs to be re-evaluated for A11Y.

Note that I find this Vertical Navigation pattern somewhat more accessible, given my color-blindness. Even this, however, is probably more subtle than it should be (and it only changes the hovered item's background color, not the text color)

Reference tokens:

"$value": "{theme.color.background}",

"$value": "{theme.color.background}",

@jack-ryan-nava-pbc
Copy link
Collaborator

Thanks for raising this @sydk-adhoc

We'll open a ticket and investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants