From ef9f421bc2eb0fcc99e19d38bbddc810e70c7e9d Mon Sep 17 00:00:00 2001 From: Martin Pulec Date: Tue, 21 Jan 2025 11:23:53 +0100 Subject: [PATCH] format_number_with_delim: simplified --- src/gpujpeg_common.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/gpujpeg_common.c b/src/gpujpeg_common.c index c5c2c55..33c77f5 100644 --- a/src/gpujpeg_common.c +++ b/src/gpujpeg_common.c @@ -2180,19 +2180,12 @@ format_number_with_delim(size_t num, char* buf, size_t buflen) const int tmp = num % 1000; num /= 1000; if ( num == 0 ) { - ptr -= 1; - if ( tmp >= 10 ) { - ptr -= 1; - if ( tmp >= 100 ) { - ptr -= 1; - } - } + char numbuf[4]; + ptr -= snprintf(numbuf, sizeof numbuf, "%i", tmp); if ( ptr < buf ) { snprintf(buf, buflen, "%s", "ERR"); return buf; } - char numbuf[4]; - snprintf(numbuf, sizeof numbuf, "%i", tmp); // NOLINTNEXTLINE(bugprone-not-null-terminated-result): prepending, no null-termination memcpy(ptr, numbuf, strlen(numbuf)); return ptr;