Fix invalid variable naming (#243)

Author: bulkowy

app/src/db.py

@@ -85,7 +85,7 @@ class ScanLogEntry(Base):  # type: ignore
 
     def __repr__(self) -> str:
         return ("<ScanLogEntry(domain='%s', source='%s', client_ip='%s', " "client_user_agent='%s')>") % (
-            self.domain,
+            self.from_domain,
             self.source,
             self.client_ip,
             self.client_user_agent,

scan/libmailgoose/scan.py

@@ -103,7 +103,6 @@ class DomainScanResult:
     spf: SPFScanResult
     dmarc: DMARCScanResult
     ssl: Optional[ssl_check.SSLScanResult]
-    domain: str
     base_domain: str
     warnings: List[str]
     domain_does_not_exist: bool
@@ -326,8 +325,7 @@ def scan_domain(
             if not parked
             else None
         ),
-        domain=domain,
-        base_domain=checkdmarc.get_base_domain(domain),
+        base_domain=checkdmarc.get_base_domain(from_domain),
         domain_does_not_exist=False,
         warnings=warnings,
     )
@@ -351,7 +349,7 @@ def scan_domain(
             try:
                 parsed_spf = checkdmarc.spf.parse_spf_record(
                     domain_result.spf.record,
-                    domain_result.domain,
+                    envelope_domain,
                     parked=parked,
                     nameservers=nameservers,
                     timeout=timeout,
@@ -446,7 +444,7 @@ def scan_domain(
                 "records may cause problems with some DMARC implementations.",
             )
             dmarc_query = checkdmarc.dmarc.query_dmarc_record(
-                domain,
+                from_domain,
                 nameservers=nameservers,
                 timeout=timeout,
                 ignore_unrelated_records=True,

test/test_api.py

@@ -36,7 +36,6 @@ def test_dmarc_starts_with_whitespace(self) -> None:
                             "record_not_found": False,
                         },
                         "spf_not_required_because_of_correct_dmarc": False,
-                        "domain": "starts-with-whitespace.dmarc.test.mailgoose.cert.pl",
                         "base_domain": "cert.pl",
                         "warnings": [],
                         "ssl": {