highlights on non "text" fields

[jduss4]

by "text" I mean literally our field named "text" in the api. Right now if you search within, say, the "annotations" field you will receive results but no highlighting. Need to adapt to return all highlights!

Questions:

• should they come back in one giant array?
• should they be returned distinctly? aka:

highlights: {
  "text" => [ 1, 2, 3 ],
  "annotations" => [ 1, 2, 3 ],
}

[karindalziel]

Hmm. That's a good question and I am not sure. My gut is saying distinctly but I think we might want to ask the cather folks.

[karindalziel]

I decided on separate for now, we could revisit later if needed!

[jduss4]

Okay! We can always make it look like the same field for the cather folks this way :)

[karindalziel]

That's what I figured, gives more styling options

[jduss4]

This appears to have been done a few days after this issue: c7a3795#diff-acac9d94ee5288332c2f7509d90ece97

A question remains for me whether or not annotations should appear by default for ALL fields being text searched when hl is true, right now you have to opt in with hl_fl but I'll open a new issue for it