Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicate “page breaks” via more than just styles #51 #54

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

chasenlehara
Copy link

Previously, the page break element was not perceivable to screen readers because it rendered no text.

Now, some text will be in the DOM for screen readers to read, while the visual representation of the page break has not changed.

Closes #51

@chasenlehara chasenlehara force-pushed the 51-page-breaks branch 2 times, most recently from f767f48 to e895af4 Compare December 9, 2021 01:46
Previously, the page break element was not perceivable to screen readers because it rendered no text.

Now, some text will be in the DOM for screen readers to read, while the visual representation of the page break has not changed.

Closes #51
Copy link
Collaborator

@mikemitchel mikemitchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@chasenlehara chasenlehara merged commit 1bc9002 into develop Dec 9, 2021
@chasenlehara chasenlehara deleted the 51-page-breaks branch December 9, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate “page breaks” via more than just styles
2 participants