City commerce

[stavrosfa]

There is something weird going on with how we calculate commerce.

For example, if we have 5 corrupt gold, we both add it and subtract it from our total income.

The same is true for beakers and happiness.

Check the Inflows() and Outflows(), they both take these values into account
https://github.com/C7-Game/Prototype/blob/9e90b4df5d32097814c6da1379057e4e79265434/C7Engine/C7GameData/Player.cs#L24

I don't really know how commerce should work in game (embarrassing, I know, but it's only been 20 or so years 😅), so I am not sure what changes to make.

[ethhics]

If I'm reading it correctly, this is having to do with the ledger calculations for the domestic advisor?

If so, then note that the domestic advisor has a "From cities" category. We don't know, from the available variables, how much gold comes from cities. But, we do know that every city turns its gold exclusively into taxes, beakers, happiness, and corruption. So if you sum those together, they yield the total city gold.

So yes they're double-counted, but it's an artifact of accounting more than anything. The inflow from those sources gets passed directly into outflows as they are really expenses at the end of the day.