Need for additional Point classes, as well as "un deprecation" of some.

[PeteHart]

@gtfierro

A number of large Swedish property owners have undertaken a joint effort to classify existing HVAC systems with Brick 1.4.1

To get consistency we've realized that some Point classes are missing and some fairly recent deprecations are needed.

The background for the requests are meticulously described in attached. In summary we suggest

Non existing classes to Add:
• Return_Air_Static_Pressure_Sensor
• Return_Air_Static_Pressure_Setpoint
• Return_Air_Flow_Setpoint
• Room_Air_Temperature_Sensor
• Zone_CO2_Level_Setpoint
• Zone_CO_Level_Sensor
• Zone_CO_Level_Setpoint
• Return_Air_CO_Setpoint
• Domestic_Hot_Water_Return_Temperature_Sensor
• Domestic_Hot_Water_Return_Temperature_Setpoint
• Water_Volume_Sensor

Deprecated classes to retain:
• Zone_Air_Temperature_Setpoint
• Hot_Water_Supply_Temperature_Sensor
• Supply_Hot_Water_Temperature_Setpoint
• Chilled_Water_Supply_Temperature_Sensor
• Supply_Chilled_Water_Temperature_Setpoint
• Hot_Water_Return_ Temperature_sensor
• Return_Hot_Water_Temperature_Setpoint
• Chilled_Water_Return_Temperature_Sensor
• Return_Chilled_Water_Temperature_Setpoint
• Hot_Water_Supply_Flow_Sensor
• Hot_Water_Return_Flow_Sensor
• Chilled_Water_Supply_Flow_Sensor
• Chilled_Water_Return_Flow_Sensor
• Domestic_Hot_Water_Supply_Temperature_Sensor
• Domestic_Hot_Water_Supply_Temperature_Setpoint

Additional requests:
• Add system: Domestic_Water_System or Domestic_Cold_Water_System
• Rename the following classes as follows:
o Hot_Water_Supply_Temperature_Sensor >> Supply_Hot_Water_Temperature_Sensor
o Chilled_Water_Supply_Temperature_Sensor >> Supply_Chilled_Water_Temperature_Sensor
o Hot_Water_Return_ Temperature_sensor >> Return_Hot_Water_Temperature_Sensor
o Chilled_Water_Return_Temperature_Sensor >> Return_Chilled_Water_Temperature_Sensor
o Hot_Water_Supply_Flow_Sensor >> Supply_Hot_Water_Flow_Sensor
o Hot_Water_Return_Flow_Sensor >> Return_Hot_Water_Flow_Sensor
o Chilled_Water_Supply_Flow_Sensor >> Supply_Chilled_Water_Flow_Sensor
o Chilled_Water_Return_Flow_Sensor >> Return_Chilled_Water_Flow_Sensor

Bricks Requests.pdf

[jahrling]

I agree.
Supply and Return are necessary for major equipment (e.g. water heaters, boilers) and within locations like a mechanical room delivering water to various zone loops. At the same time, Entering and Leaving are necessary when it comes to valves or other devices/equipment on the system loops or domestic cold water system (not addressed in Brick today). I'm guessing that having "entering/leaving" for water-related points may have been done with a focus on air-side HVAC systems that use boiler water in the HX.

[gtfierro]

@jahrling and @PeteHart I'm working on this PR today (finally!) Is there a good "rule of thumb" definition for when to use Supply/Return vs Entering/Leaving? I can see the examples in the provided document but I want to document this terminology on docs.brickschema.org so I can make sure we get it right going forward

[jahrling]

I can speak about water heaters and boilers. Those equipment types will have specific Supply and Return ports for the water to do just that. I have not heard this referenced from the perspective of pipes other than when you are either at the end of the loop and there are no more downstream fixtures/fittings (domestic hot water) or heat exchangers / radiators (hydronic water), or at the very beginning of the loop and there is nothing upstream.

In those cases, the water is being used as a part of a loop. Going through a valve does not necessarily mean that it is part of a loop (like for potable cold) and therefore there is no return. When I read it in Brick, I thought it was clever to use Entering and Leaving because it was from the perspective of a given object (location, equipment, fitting, etc.), nor part of the "product fluid."

May want to reference a domain dictionary. Looks like supply and return apply to loops, and entering and leaving may refer to the refrigeration or HX lines.
https://aspe.org/publications-news/plumbineering-dictionary/
supply pipe - A pipe used to convey supply gas or water.
return line - Part of a circulating system that returns a fluid to its source point.

https://forms.iapmo.org/asse/free_dictionary.html
supply pipe - a branch pipe of the principal supply pipe. A pipe which supplies a service gas, water, etc., to one, or more, fixtures or stations
return line - part of a circulating system in which the restoration to the point of a source is accomplished.

https://terminology.ashrae.org/
supply air - (1) air delivered by mechanical or natural ventilation to a space, composed of any combination of outdoor air, recirculated air, or transfer air. (2) air entering a space from an air-conditioning, heating, or ventilating apparatus for the purpose of comfort conditioning. Supply air is generally filtered, fan forced, and either heated, cooled, humidified, or dehumidified as necessary to maintain specified conditions. Only the quantity of outdoor air within the supply airflow may be used as replacement air.
return - pipe or duct to carry fluid back to the source.
net cooler refrigerating capacity - rate of heat removal from a fluid flowing through a cooler (air, water, brine, etc.) at stated conditions, the difference in specific enthalpies of the cooling fluid entering and leaving the cooler.
total refrigerating effect - (water or brine cooler), product of the mass rate of refrigerant flow and the difference in enthalpy of the entering and leaving refrigerant fluid, expressed in heat units per unit of time.

[JoelBender]

From the ASHRAE 223 perspective, we decided on Inlet and Outlet for the same reason, they are from the perspective of a piece of equipment. It's not uncommon to have the "Supply Air" duct carry that label from an AHU all the way down to the space/room, even when there is additional inline equipment like a fan powered terminal unit that also has a reheat coil.

For the Hot_Water_Supply_Temperature_Sensor >> Supply_Hot_Water_Temperature_Sensor rename, this is part of what I call the Big Red Hairy Dog problem, and is language/region specific. Our naming conventions are things like BartonHall.HW.STemp for grouping with BartonHall.HW.RTemp, ...Flow, etc., which is both syntactically and semantically useful. I would prefer these to remain as they are.

For some additional perspective, I've seen control sequence parameter names like Tsa, or "temperature (of the) supply air." Ugh!