Merge pull request #2796 from BrentOzarULTD/dev

2021-02 Release

Author: BrentOzar

Documentation/Development/Merge Blitz.ps1

@@ -1,32 +1,39 @@
 #Set your file path
 $FilePath = "C:\temp\SQL-Server-First-Responder-Kit"
 $SqlVersionsPath = "$FilePath\SqlServerVersions.sql"
+$BlitzFirstPath = "$FilePath\sp_BlitzFirst.sql"
 
 #All Core Blitz Without sp_BlitzQueryStore
 Get-ChildItem -Path "$FilePath" -Filter "sp_Blitz*.sql" |
-Where-Object { $_.FullName -notlike "*sp_BlitzQueryStore.sql*" -and $_.FullName -notlike "*sp_BlitzInMemoryOLTP*"} |
+Where-Object { $_.FullName -notlike "*sp_BlitzQueryStore.sql*" -and $_.FullName -notlike "*sp_BlitzInMemoryOLTP*" -and $_.FullName -notlike "*sp_BlitzFirst*" -and $_.FullName -notlike "*sp_BlitzAnalysis*"} |
 ForEach-Object { Get-Content $_.FullName } | 
 Set-Content -Path "$FilePath\Install-Core-Blitz-No-Query-Store.sql" -Force
 #append script to (re-)create SqlServerVersions Table (https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/2429)
 if ( test-path "$SqlVersionsPath")
 	{ Add-Content -Path "$FilePath\Install-Core-Blitz-No-Query-Store.sql" -Value (Get-Content -Path "$SqlVersionsPath")}
+if ( test-path "$BlitzFirstPath")
+	{ Add-Content -Path "$FilePath\Install-Core-Blitz-No-Query-Store.sql" -Value (Get-Content -Path "$BlitzFirstPath")}
 
 
 #All Core Blitz With sp_BlitzQueryStore
 Get-ChildItem -Path "$FilePath" -Filter "sp_Blitz*.sql" |
-Where-Object { $_.FullName -notlike "*sp_BlitzInMemoryOLTP*"} |
+Where-Object { $_.FullName -notlike "*sp_BlitzInMemoryOLTP*" -and $_.FullName -notlike "*sp_BlitzFirst*" -and $_.FullName -notlike "*sp_BlitzAnalysis*"} |
 ForEach-Object { Get-Content $_.FullName } | 
 Set-Content -Path "$FilePath\Install-Core-Blitz-With-Query-Store.sql" -Force
 #append script to (re-)create SqlServerVersions Table (https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/2429)
 if ( test-path "$SqlVersionsPath")
 	{ Add-Content -Path "$FilePath\Install-Core-Blitz-With-Query-Store.sql" -Value (Get-Content -Path "$SqlVersionsPath")}
+if ( test-path "$BlitzFirstPath")
+	{ Add-Content -Path "$FilePath\Install-Core-Blitz-With-Query-Store.sql" -Value (Get-Content -Path "$BlitzFirstPath")}
 
 
 #All Scripts
 Get-ChildItem -Path "$FilePath" -Filter "sp_*.sql" |
-Where-Object { $_.FullName -notlike "*sp_BlitzInMemoryOLTP*"} |
+Where-Object { $_.FullName -notlike "*sp_BlitzInMemoryOLTP*" -and $_.FullName -notlike "*sp_BlitzFirst*" -and $_.FullName -notlike "*sp_BlitzAnalysis*"} |
 ForEach-Object { Get-Content $_.FullName } | 
 Set-Content -Path "$FilePath\Install-All-Scripts.sql" -Force
 #append script to (re-)create SqlServerVersions Table (https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/2429)
 if ( test-path "$SqlVersionsPath")
 	{ Add-Content -Path "$FilePath\Install-All-Scripts.sql" -Value (Get-Content -Path "$SqlVersionsPath")}
+if ( test-path "$BlitzFirstPath")
+	{ Add-Content -Path "$FilePath\Install-All-Scripts.sql" -Value (Get-Content -Path "$BlitzFirstPath")}

Documentation/sp_BlitzFirst_Checks_by_Priority.md

@@ -6,8 +6,8 @@ Before adding a new check, make sure to add a Github issue for it first, and hav
 
 If you want to change anything about a check - the priority, finding, URL, or ID - open a Github issue first. The relevant scripts have to be updated too.
 
-CURRENT HIGH CHECKID: 46
-If you want to add a new check, start at 47
+CURRENT HIGH CHECKID: 47
+If you want to add a new check, start at 48
 
 | Priority | FindingsGroup | Finding | URL | CheckID |
 |----------|---------------------------------|---------------------------------------|-------------------------------------------------|----------|
@@ -34,6 +34,7 @@ If you want to add a new check, start at 47
 | 50 | Query Problems | Plan Cache Erased Recently | https://BrentOzar.com/go/freeproccache | 7 |
 | 50 | Query Problems | Re-Compilations/Sec High | https://BrentOzar.com/go/recompile | 16 |
 | 50 | Query Problems | Statistics Updated Recently | https://BrentOzar.com/go/stats | 44 |
+| 50 | Query Problems | High Percentage Of Runnable Queries | https://erikdarlingdata.com/go/RunnableQueue/ | 47 |
 | 50 | Server Performance | High CPU Utilization | https://BrentOzar.com/go/cpu | 24 |
 | 50 | Server Performance | High CPU Utilization - Non SQL Processes | https://BrentOzar.com/go/cpu | 28 |
 | 50 | Server Performance | Slow Data File Reads | https://BrentOzar.com/go/slow | 11 |

Install-All-Scripts.sql

@@ -22,7 +22,8 @@ Navigation
    - [sp_BlitzInMemoryOLTP: Hekaton Analysis](#sp_blitzinmemoryoltp-hekaton-analysis) 
    - [sp_BlitzLock: Deadlock Analysis](#sp_blitzlock-deadlock-analysis) 
    - [sp_BlitzQueryStore: Like BlitzCache, for Query Store](#sp_blitzquerystore-query-store-sale)
-   - [sp_BlitzWho: What Queries are Running Now](#sp_blitzwho-what-queries-are-running-now)
+   - [sp_BlitzWho: What Queries are Running Now](#sp_blitzwho-what-queries-are-running-now)   
+   - [sp_BlitzAnalysis: Query sp_BlitzFirst output tables](#sp_blitzanalysis-query-sp_BlitzFirst-output-tables) 
  - Backups and Restores:
    - [sp_BlitzBackups: How Much Data Could You Lose](#sp_blitzbackups-how-much-data-could-you-lose)  
    - [sp_AllNightLog: Back Up Faster to Lose Less Data](#sp_allnightlog-back-up-faster-to-lose-less-data)  
@@ -43,7 +44,7 @@ The First Responder Kit runs on:
 
 * SQL Server 2012, 2014, 2016, 2017, 2019 on Windows - fully supported.
 * SQL Server 2017, 2019 on Linux - yes, fully supported except sp_AllNightLog and sp_DatabaseRestore, which require xp_cmdshell, which Microsoft doesn't provide on Linux.
-* SQL Server 2008, 200R2 - not officially supported since it's out of Microsoft support, but we try not to make changes that would break functionality here.
+* SQL Server 2008, 2008R2 - not officially supported since it's out of Microsoft support, but we try not to make changes that would break functionality here.
 * SQL Server 2000, 2005 - not supported at all.
 * Amazon RDS SQL Server - fully supported.
 * Azure SQL DB - not supported. Some of the procedures work, but some don't, and Microsoft has a tendency to change DMVs in Azure without warning, so we don't put any effort into supporting it. If it works, great! If not, any changes to make it work would be on you. [See the contributing.md file](CONTRIBUTING.md) for how to do that.
@@ -364,6 +365,88 @@ It's designed for query tuners, so it includes things like memory grants, degree
 [*Back to top*](#header1)
 
 
+## sp_BlitzAnalysis: Query sp_BlitzFirst output tables
+
+Retrieves data from the output tables where you are storing your sp_BlitzFirst output.
+
+Parameters include:
+
+* @StartDate: When you want to start seeing data from , NULL will set @StartDate to 1 hour ago.
+* @EndDate: When you want to see data up to, NULL will get an hour of data since @StartDate.
+* @Databasename: Filter results by database name where possible, Default: NULL which shows all.
+* @Servername: Filter results by server name, Default: @@SERVERNAME.
+* @OutputDatabaseName: Specify the database name where where we can find your logged sp_BlitzFirst Output table data
+* @OutputSchemaName: Schema which the sp_BlitzFirst Output tables belong to
+* @OutputTableNameBlitzFirst: Table name where you are storing sp_BlitzFirst @OutputTableNameBlitzFirst output, we default to BlitzFirst - you can Set to NULL to skip lookups against this table  
+* @OutputTableNameFileStats: Table name where you are storing sp_BlitzFirst @OutputTableNameFileStats output, we default to BlitzFirst_FileStats - you can Set to NULL to skip lookups against this table.  
+* @OutputTableNamePerfmonStats: Table name where you are storing sp_BlitzFirst @OutputTableNamePerfmonStats output, we default to BlitzFirst_PerfmonStats - you can Set to NULL to skip lookups against this table.	
+* @OutputTableNameWaitStats: Table name where you are storing sp_BlitzFirst @OutputTableNameWaitStats output, we default to BlitzFirst_WaitStats - you can Set to NULL to skip lookups against this table.
+* @OutputTableNameBlitzCache: Table name where you are storing sp_BlitzFirst @OutputTableNameBlitzCache output, we default to BlitzCache - you can Set to NULL to skip lookups against this table.
+* @OutputTableNameBlitzWho: Table name where you are storing sp_BlitzFirst @OutputTableNameBlitzWho output, we default to BlitzWho - you can Set to NULL to skip lookups against this table.	
+* @MaxBlitzFirstPriority: Max priority to include in the results from your BlitzFirst table, Default: 249.
+* @BlitzCacheSortorder: Controls the results returned from your BlitzCache table, you will get a TOP 5 per sort order per CheckDate, Default: 'cpu' Accepted values 'all' 'cpu' 'reads' 'writes' 'duration' 'executions' 'memory grant' 'spills'.
+* @WaitStatsTop: Controls the Top X waits per CheckDate from your  wait stats table, Default: 10.
+* @ReadLatencyThreshold: Sets the threshold in ms to compare against io_stall_read_average_ms in your filestats table, Default: 100.
+* @WriteLatencyThreshold: Sets the threshold in ms to compare against io_stall_write_average_ms in your filestats table, Default: 100.
+* @BringThePain: If you are getting more than 4 hours of data from your BlitzCache table with @BlitzCacheSortorder set to 'all' you will need to set BringThePain to 1.
+* @Maxdop: Control the degree of parallelism that the queries within this proc can use if they want to, Default = 1.
+* @Debug: Show sp_BlitzAnalysis SQL commands in the messages tab as they execute.
+
+Example calls: 
+
+Get information for the last hour from all sp_BlitzFirst output tables
+
+```SQL
+EXEC sp_BlitzAnalysis 
+	@FromDate = NULL,
+	@ToDate = NULL,	
+	@OutputDatabaseName = 'DBAtools',
+	@OutputSchemaName = 'dbo',
+	@OutputTableNameFileStats = N'BlitzFirst_FileStats',		
+	@OutputTableNamePerfmonStats  = N'BlitzFirst_PerfmonStats',		
+	@OutputTableNameWaitStats = N'BlitzFirst_WaitStats',		 
+	@OutputTableNameBlitzCache = N'BlitzCache',		 
+	@OutputTableNameBlitzWho = N'BlitzWho';
+```
+
+Exclude specific tables e.g lets exclude PerfmonStats by setting to NULL, no lookup will occur against the table and a skipped message will appear in the resultset
+
+```SQL
+EXEC sp_BlitzAnalysis 
+	@FromDate = NULL,
+	@ToDate = NULL,	
+	@OutputDatabaseName = 'DBAtools',
+	@OutputSchemaName = 'Blitz',
+	@OutputTableNameFileStats = N'BlitzFirst_FileStats',		
+	@OutputTableNamePerfmonStats  = NULL,		
+	@OutputTableNameWaitStats = N'BlitzFirst_WaitStats',		 
+	@OutputTableNameBlitzCache = N'BlitzCache',		 
+	@OutputTableNameBlitzWho = N'BlitzWho';
+```
+
+Known issues: 
+We are likely to be hitting some big tables here and some of these queries will require scans of the clustered indexes as there are no nonclustered indexes to cover the queries by default, keep this in mind if you are planning on running this in a production environment!
+
+I have noticed that the Perfmon query can ask for a big memory grant so be mindful when including this table with large volumes of data:
+
+```SQL
+SELECT 
+    [ServerName]
+	,[CheckDate]
+	,[counter_name]
+    ,[object_name]
+    ,[instance_name]
+    ,[cntr_value]
+FROM [dbo].[BlitzFirst_PerfmonStats_Actuals]
+WHERE CheckDate BETWEEN @FromDate AND @ToDate
+ORDER BY 
+	[CheckDate] ASC,
+	[counter_name] ASC
+```
+	
+[*Back to top*](#header1)
+
+
 ## sp_BlitzBackups: How Much Data Could You Lose
 
 Checks your backups and reports estimated RPO and RTO based on historical data in msdb, or a centralized location for [msdb].dbo.backupset.

Install-Core-Blitz-No-Query-Store.sql

@@ -41,6 +41,7 @@ DELETE FROM dbo.SqlServerVersions;
 INSERT INTO dbo.SqlServerVersions
     (MajorVersionNumber, MinorVersionNumber, Branch, [Url], ReleaseDate, MainstreamSupportEndDate, ExtendedSupportEndDate, MajorVersionName, MinorVersionName)
 VALUES
+    (15, 4102, 'CU9', 'https://support.microsoft.com/en-us/help/5000642', '2021-02-11', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 9 '),
     (15, 4073, 'CU8 GDR', 'https://support.microsoft.com/en-us/help/4583459', '2021-01-12', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 8 GDR '),
     (15, 4073, 'CU8', 'https://support.microsoft.com/en-us/help/4577194', '2020-10-01', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 8 '),
     (15, 4063, 'CU7', 'https://support.microsoft.com/en-us/help/4570012', '2020-09-02', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 7 '),
@@ -76,6 +77,7 @@ VALUES
     (14, 3008, 'RTM CU2', 'https://support.microsoft.com/en-us/help/4052574', '2017-11-28', '2022-10-11', '2027-10-12', 'SQL Server 2017', 'RTM Cumulative Update 2'),
     (14, 3006, 'RTM CU1', 'https://support.microsoft.com/en-us/help/4038634', '2017-10-24', '2022-10-11', '2027-10-12', 'SQL Server 2017', 'RTM Cumulative Update 1'),
     (14, 1000, 'RTM ', '', '2017-10-02', '2022-10-11', '2027-10-12', 'SQL Server 2017', 'RTM '),
+    (13, 5882, 'SP2 CU16', 'https://support.microsoft.com/en-us/help/5000645', '2021-02-11', '2021-07-13', '2026-07-14', 'SQL Server 2016', 'Service Pack 2 Cumulative Update 16'),
     (13, 5865, 'SP2 CU15 GDR', 'https://support.microsoft.com/en-us/help/4583461', '2021-01-12', '2021-07-13', '2026-07-14', 'SQL Server 2016', 'Service Pack 2 Cumulative Update 15 GDR'),
     (13, 5850, 'SP2 CU15', 'https://support.microsoft.com/en-us/help/4577775', '2020-09-28', '2021-07-13', '2026-07-14', 'SQL Server 2016', 'Service Pack 2 Cumulative Update 15'),
     (13, 5830, 'SP2 CU14', 'https://support.microsoft.com/en-us/help/4564903', '2020-08-06', '2021-07-13', '2026-07-14', 'SQL Server 2016', 'Service Pack 2 Cumulative Update 14'),

Install-Core-Blitz-With-Query-Store.sql

@@ -17,6 +17,7 @@ IF OBJECT_ID('tempdb.dbo.#ToDelete') IS NOT NULL
 SELECT 'sp_AllNightLog' as ProcedureName INTO #ToDelete UNION
 SELECT 'sp_AllNightLog_Setup' as ProcedureName UNION
 SELECT 'sp_Blitz' as ProcedureName UNION
+SELECT 'sp_BlitzAnalysis' as ProcedureName UNION
 SELECT 'sp_BlitzBackups' as ProcedureName UNION
 SELECT 'sp_BlitzCache' as ProcedureName UNION
 SELECT 'sp_BlitzFirst' as ProcedureName UNION

README.md

@@ -30,7 +30,7 @@ SET NOCOUNT ON;
 BEGIN;
 
 
-SELECT @Version = '8.0', @VersionDate = '20210117';
+SELECT @Version = '8.01', @VersionDate = '20210222';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -349,7 +349,7 @@ Pollster:
 							SELECT 1
 							FROM msdbCentral.dbo.backup_worker bw WITH (READPAST)
 							WHERE bw.last_log_backup_finish_time < '99991231'
-							AND bw.last_log_backup_start_time < DATEADD(MINUTE, -5, GETDATE())				
+							AND bw.last_log_backup_start_time < DATEADD(SECOND, (@rpo * -1), GETDATE())				
 							AND EXISTS (
 									SELECT 1
 									FROM msdb.dbo.backupset b
@@ -369,7 +369,7 @@ Pollster:
 												bw.last_log_backup_start_time = '19000101'
 									FROM msdbCentral.dbo.backup_worker bw
 									WHERE bw.last_log_backup_finish_time < '99991231'
-									AND bw.last_log_backup_start_time < DATEADD(MINUTE, -5, GETDATE())
+									AND bw.last_log_backup_start_time < DATEADD(SECOND, (@rpo * -1), GETDATE())
 									AND EXISTS (
 											SELECT 1
 											FROM msdb.dbo.backupset b
@@ -583,7 +583,7 @@ DiskPollster:
 							SELECT 1
 							FROM msdb.dbo.restore_worker rw WITH (READPAST)
 							WHERE rw.last_log_restore_finish_time < '99991231'
-							AND rw.last_log_restore_start_time < DATEADD(MINUTE, -5, GETDATE())				
+							AND rw.last_log_restore_start_time < DATEADD(SECOND, (@rto * -1), GETDATE())			
 							AND EXISTS (
 									SELECT 1
 									FROM msdb.dbo.restorehistory r
@@ -603,7 +603,7 @@ DiskPollster:
 												rw.last_log_restore_start_time = '19000101'
 									FROM msdb.dbo.restore_worker rw
 									WHERE rw.last_log_restore_finish_time < '99991231'
-									AND rw.last_log_restore_start_time < DATEADD(MINUTE, -5, GETDATE())
+									AND rw.last_log_restore_start_time < DATEADD(SECOND, (@rto * -1), GETDATE())
 									AND EXISTS (
 											SELECT 1
 											FROM msdb.dbo.restorehistory r

SqlServerVersions.sql

@@ -36,7 +36,7 @@ SET NOCOUNT ON;
 
 BEGIN;
 
-SELECT @Version = '8.0', @VersionDate = '20210117';
+SELECT @Version = '8.01', @VersionDate = '20210222';
 
 IF(@VersionCheckMode = 1)
 BEGIN