Skip to content

Commit 5512d3e

Browse files
authored
Merge pull request #306 from BranchMetrics/rating-average
Field mapping
2 parents 9773769 + ded7ad9 commit 5512d3e

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

ios/BranchContentMetadata+RNBranch.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ @implementation BranchContentMetadata(RNBranch)
2828
@"productCategory": [RNBranchProperty propertyWithSetterSelector:@selector(setProductCategory:) type:NSString.class],
2929
@"productVariant": [RNBranchProperty propertyWithSetterSelector:@selector(setProductVariant:) type:NSString.class],
3030
@"condition": [RNBranchProperty propertyWithSetterSelector:@selector(setCondition:) type:NSString.class],
31-
@"ratingAverage": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingAverage:) type:NSNumber.class],
31+
@"ratingAverage": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingAverageWithNumber:) type:NSNumber.class],
3232
@"ratingCount": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingCountWithNumber:) type:NSNumber.class],
3333
@"ratingMax": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingMaxWithNumber:) type:NSNumber.class],
3434
@"addressStreet": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressStreet:) type:NSString.class],

ios/RNBranch.m

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,14 @@ - (BranchUniversalObject *)findUniversalObjectWithIdent:(NSString *)ident reject
393393
}
394394

395395
event.contentItems = buos;
396+
if ([eventName isEqualToString:BranchStandardEventViewItem] && params.count == 0) {
397+
for (BranchUniversalObject *buo in buos) {
398+
if (!buo.locallyIndex) continue;
399+
// for now at least, pending possible changes to the native SDK
400+
[buo listOnSpotlight];
401+
}
402+
}
403+
396404
[event logEvent];
397405
resolve(NSNull.null);
398406
}

src/branchUniversalObject.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ export default async function createBranchUniversalObject(identifier, options =
8383
},
8484
userCompletedAction(event, state = {}) {
8585
console.info('[Branch] userCompletedAction is deprecated. Please use logEvent or the BranchEvent class instead.')
86+
if (event == RNBranch.REGISTER_VIEW_EVENT) {
87+
return this.logEvent(BranchEvent.ViewItem, { customData: state })
88+
}
8689
return this._tryFunction(RNBranch.userCompletedActionOnUniversalObject, event, state)
8790
},
8891
logEvent(eventName, params = {}) {

0 commit comments

Comments
 (0)