Skip to content

Commit 4043484

Browse files
gdeluna-branchgdeluna-branch
authored
Merge pull request #44 from gdeluna-branch/gdeluna-branch/Release-3.12.2
Release 3.12.2
2 parents 26d4a43 + b4ff078 commit 4043484

14 files changed

+237
-15
lines changed

‎BranchSDK.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "BranchSDK"
3-
s.version = "3.12.1"
3+
s.version = "3.12.2"
44
s.summary = "Create an HTTP URL for any piece of content in your app"
55
s.description = <<-DESC
66
- Want the highest possible conversions on your sharing feature?

‎BranchSDK.xcodeproj/project.pbxproj‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,15 @@
5454
/* End PBXAggregateTarget section */
5555

5656
/* Begin PBXBuildFile section */
57+
4D4445A42E2F7138004E065F /* BranchConfigurationController.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D4445A32E2F7138004E065F /* BranchConfigurationController.h */; };
58+
4D4445A52E2F7138004E065F /* BranchConfigurationController.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D4445A32E2F7138004E065F /* BranchConfigurationController.h */; };
59+
4D4445A62E2F7138004E065F /* BranchConfigurationController.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D4445A32E2F7138004E065F /* BranchConfigurationController.h */; };
60+
4D4445A82E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
61+
4D4445A92E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
62+
4D4445AA2E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
63+
4D4445AB2E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
64+
4D4445AC2E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
65+
4D4445AD2E2F71D0004E065F /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */; };
5766
5F2211722894A9C000C5B190 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5F2211712894A9C000C5B190 /* AppDelegate.swift */; };
5867
5F2211742894A9C000C5B190 /* SceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5F2211732894A9C000C5B190 /* SceneDelegate.swift */; };
5968
5F2211762894A9C000C5B190 /* ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5F2211752894A9C000C5B190 /* ViewController.swift */; };
@@ -545,6 +554,10 @@
545554
/* End PBXCopyFilesBuildPhase section */
546555

547556
/* Begin PBXFileReference section */
557+
4D4445A32E2F7138004E065F /* BranchConfigurationController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BranchConfigurationController.h; sourceTree = "<group>"; };
558+
4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BranchConfigurationController.m; sourceTree = "<group>"; };
559+
4D4445AE2E2F71D3004E065F /* TestHostTests-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "TestHostTests-Bridging-Header.h"; sourceTree = "<group>"; };
560+
4D4445AF2E2F71D3004E065F /* TestHostUITests-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "TestHostUITests-Bridging-Header.h"; sourceTree = "<group>"; };
548561
5F22101D2894A0DB00C5B190 /* BranchSDK.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = BranchSDK.framework; sourceTree = BUILT_PRODUCTS_DIR; };
549562
5F22116F2894A9C000C5B190 /* TestHost.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = TestHost.app; sourceTree = BUILT_PRODUCTS_DIR; };
550563
5F2211712894A9C000C5B190 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
@@ -884,6 +897,7 @@
884897
5FCDD3942B7AC6A100EAF29F /* BranchCSSearchableItemAttributeSet.m */,
885898
5FCDD3E52B7AC6A100EAF29F /* BranchDelegate.m */,
886899
5FCDD3F82B7AC6A100EAF29F /* BranchEvent.m */,
900+
4D4445A72E2F71D0004E065F /* BranchConfigurationController.m */,
887901
5FCDD37A2B7AC6A100EAF29F /* BranchInstallRequest.m */,
888902
5FCDD3912B7AC6A100EAF29F /* BranchJsonConfig.m */,
889903
5FCDD3EA2B7AC6A100EAF29F /* BranchLastAttributedTouchData.m */,
@@ -906,6 +920,8 @@
906920
5FCDD3F52B7AC6A100EAF29F /* UIViewController+Branch.m */,
907921
5FCDD3B42B7AC6A100EAF29F /* Private */,
908922
5FCDD3982B7AC6A100EAF29F /* Public */,
923+
4D4445AE2E2F71D3004E065F /* TestHostTests-Bridging-Header.h */,
924+
4D4445AF2E2F71D3004E065F /* TestHostUITests-Bridging-Header.h */,
909925
);
910926
name = BranchSDK;
911927
path = Sources/BranchSDK;
@@ -980,6 +996,7 @@
980996
5FCDD3CA2B7AC6A100EAF29F /* BNCUserAgentCollector.h */,
981997
E7F311B02DACB54100F824A7 /* BNCODMInfoCollector.h */,
982998
5FCDD3D32B7AC6A100EAF29F /* Branch+Validator.h */,
999+
4D4445A32E2F7138004E065F /* BranchConfigurationController.h */,
9831000
5FCDD3DC2B7AC6A100EAF29F /* BranchConstants.h */,
9841001
5FCDD3D82B7AC6A100EAF29F /* BranchContentDiscoverer.h */,
9851002
5FCDD3DA2B7AC6A100EAF29F /* BranchContentDiscoveryManifest.h */,
@@ -1103,6 +1120,7 @@
11031120
5FCDD54F2B7AC6A300EAF29F /* BranchJsonConfig.h in Headers */,
11041121
5FCDD4E02B7AC6A200EAF29F /* BNCSKAdNetwork.h in Headers */,
11051122
5FCDD5102B7AC6A300EAF29F /* BNCDeviceSystem.h in Headers */,
1123+
4D4445A62E2F7138004E065F /* BranchConfigurationController.h in Headers */,
11061124
5FCDD51F2B7AC6A300EAF29F /* BNCNetworkInterface.h in Headers */,
11071125
5FA71BA82B7AE6B2008009CA /* Branch.h in Headers */,
11081126
);
@@ -1186,6 +1204,7 @@
11861204
5FCDD4D82B7AC6A200EAF29F /* BNCAppleReceipt.h in Headers */,
11871205
5FCDD5502B7AC6A300EAF29F /* BranchJsonConfig.h in Headers */,
11881206
5FCDD4E12B7AC6A200EAF29F /* BNCSKAdNetwork.h in Headers */,
1207+
4D4445A42E2F7138004E065F /* BranchConfigurationController.h in Headers */,
11891208
5FCDD5112B7AC6A300EAF29F /* BNCDeviceSystem.h in Headers */,
11901209
5FCDD5202B7AC6A300EAF29F /* BNCNetworkInterface.h in Headers */,
11911210
);
@@ -1269,6 +1288,7 @@
12691288
5FCDD4D92B7AC6A200EAF29F /* BNCAppleReceipt.h in Headers */,
12701289
5FCDD5512B7AC6A300EAF29F /* BranchJsonConfig.h in Headers */,
12711290
5FCDD4E22B7AC6A200EAF29F /* BNCSKAdNetwork.h in Headers */,
1291+
4D4445A52E2F7138004E065F /* BranchConfigurationController.h in Headers */,
12721292
5FCDD5122B7AC6A300EAF29F /* BNCDeviceSystem.h in Headers */,
12731293
5FCDD5212B7AC6A300EAF29F /* BNCNetworkInterface.h in Headers */,
12741294
);
@@ -1408,10 +1428,12 @@
14081428
};
14091429
5F2211832894A9C100C5B190 = {
14101430
CreatedOnToolsVersion = 13.4.1;
1431+
LastSwiftMigration = 1620;
14111432
TestTargetID = 5F22116E2894A9C000C5B190;
14121433
};
14131434
5F22118D2894A9C100C5B190 = {
14141435
CreatedOnToolsVersion = 13.4.1;
1436+
LastSwiftMigration = 1620;
14151437
TestTargetID = 5F22116E2894A9C000C5B190;
14161438
};
14171439
5F73EBF328ECE65400608601 = {
@@ -1627,6 +1649,7 @@
16271649
5FCDD42C2B7AC6A100EAF29F /* BranchPluginSupport.m in Sources */,
16281650
5FCDD5A62B7AC6A400EAF29F /* BNCQRCodeCache.m in Sources */,
16291651
5FCDD45C2B7AC6A100EAF29F /* BNCReachability.m in Sources */,
1652+
4D4445A82E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
16301653
5FCDD42F2B7AC6A100EAF29F /* NSString+Branch.m in Sources */,
16311654
5FCDD5A02B7AC6A400EAF29F /* BranchShortUrlRequest.m in Sources */,
16321655
5FCDD46B2B7AC6A100EAF29F /* BNCServerInterface.m in Sources */,
@@ -1672,13 +1695,15 @@
16721695
5F6DD24C2894AF5E00AE9FB0 /* NSURLSession+Branch.m in Sources */,
16731696
5F2211722894A9C000C5B190 /* AppDelegate.swift in Sources */,
16741697
5F2211742894A9C000C5B190 /* SceneDelegate.swift in Sources */,
1698+
4D4445AA2E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
16751699
);
16761700
runOnlyForDeploymentPostprocessing = 0;
16771701
};
16781702
5F2211802894A9C100C5B190 /* Sources */ = {
16791703
isa = PBXSourcesBuildPhase;
16801704
buildActionMask = 2147483647;
16811705
files = (
1706+
4D4445AB2E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
16821707
5F2211892894A9C100C5B190 /* TestHostTests.swift in Sources */,
16831708
);
16841709
runOnlyForDeploymentPostprocessing = 0;
@@ -1687,6 +1712,7 @@
16871712
isa = PBXSourcesBuildPhase;
16881713
buildActionMask = 2147483647;
16891714
files = (
1715+
4D4445AD2E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
16901716
5F2211952894A9C100C5B190 /* TestHostUITestsLaunchTests.swift in Sources */,
16911717
5F2211932894A9C100C5B190 /* TestHostUITests.swift in Sources */,
16921718
);
@@ -1734,6 +1760,7 @@
17341760
5FCDD42D2B7AC6A100EAF29F /* BranchPluginSupport.m in Sources */,
17351761
5FCDD5A72B7AC6A400EAF29F /* BNCQRCodeCache.m in Sources */,
17361762
5FCDD45D2B7AC6A100EAF29F /* BNCReachability.m in Sources */,
1763+
4D4445A92E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
17371764
5FCDD4302B7AC6A100EAF29F /* NSString+Branch.m in Sources */,
17381765
5FCDD5A12B7AC6A400EAF29F /* BranchShortUrlRequest.m in Sources */,
17391766
5FCDD46C2B7AC6A100EAF29F /* BNCServerInterface.m in Sources */,
@@ -1829,6 +1856,7 @@
18291856
5FCDD44C2B7AC6A100EAF29F /* BranchContentDiscoveryManifest.m in Sources */,
18301857
5FCDD46A2B7AC6A100EAF29F /* BNCCrashlyticsWrapper.m in Sources */,
18311858
5FCDD43D2B7AC6A100EAF29F /* BNCServerRequest.m in Sources */,
1859+
4D4445AC2E2F71D0004E065F /* BranchConfigurationController.m in Sources */,
18321860
5FCDD5842B7AC6A400EAF29F /* BranchLinkProperties.m in Sources */,
18331861
5FCDD59F2B7AC6A400EAF29F /* BranchEvent.m in Sources */,
18341862
5FCDD5812B7AC6A400EAF29F /* BNCAppleReceipt.m in Sources */,
@@ -2157,6 +2185,7 @@
21572185
buildSettings = {
21582186
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
21592187
BUNDLE_LOADER = "$(TEST_HOST)";
2188+
CLANG_ENABLE_MODULES = YES;
21602189
CODE_SIGN_STYLE = Automatic;
21612190
CURRENT_PROJECT_VERSION = 1;
21622191
DEVELOPMENT_TEAM = R63EM248DP;
@@ -2167,6 +2196,7 @@
21672196
PRODUCT_NAME = "$(TARGET_NAME)";
21682197
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
21692198
SWIFT_EMIT_LOC_STRINGS = NO;
2199+
SWIFT_OBJC_BRIDGING_HEADER = "Sources/BranchSDK/TestHostTests-Bridging-Header.h";
21702200
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
21712201
SWIFT_VERSION = 5.0;
21722202
TARGETED_DEVICE_FAMILY = "1,2";
@@ -2179,6 +2209,7 @@
21792209
buildSettings = {
21802210
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
21812211
BUNDLE_LOADER = "$(TEST_HOST)";
2212+
CLANG_ENABLE_MODULES = YES;
21822213
CODE_SIGN_STYLE = Automatic;
21832214
CURRENT_PROJECT_VERSION = 1;
21842215
DEVELOPMENT_TEAM = R63EM248DP;
@@ -2189,6 +2220,7 @@
21892220
PRODUCT_NAME = "$(TARGET_NAME)";
21902221
SWIFT_COMPILATION_MODE = wholemodule;
21912222
SWIFT_EMIT_LOC_STRINGS = NO;
2223+
SWIFT_OBJC_BRIDGING_HEADER = "Sources/BranchSDK/TestHostTests-Bridging-Header.h";
21922224
SWIFT_OPTIMIZATION_LEVEL = "-O";
21932225
SWIFT_VERSION = 5.0;
21942226
TARGETED_DEVICE_FAMILY = "1,2";
@@ -2200,6 +2232,7 @@
22002232
isa = XCBuildConfiguration;
22012233
buildSettings = {
22022234
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
2235+
CLANG_ENABLE_MODULES = YES;
22032236
CODE_SIGN_STYLE = Automatic;
22042237
CURRENT_PROJECT_VERSION = 1;
22052238
DEVELOPMENT_TEAM = R63EM248DP;
@@ -2209,6 +2242,7 @@
22092242
PRODUCT_NAME = "$(TARGET_NAME)";
22102243
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
22112244
SWIFT_EMIT_LOC_STRINGS = NO;
2245+
SWIFT_OBJC_BRIDGING_HEADER = "Sources/BranchSDK/TestHostUITests-Bridging-Header.h";
22122246
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
22132247
SWIFT_VERSION = 5.0;
22142248
TARGETED_DEVICE_FAMILY = "1,2";
@@ -2220,6 +2254,7 @@
22202254
isa = XCBuildConfiguration;
22212255
buildSettings = {
22222256
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
2257+
CLANG_ENABLE_MODULES = YES;
22232258
CODE_SIGN_STYLE = Automatic;
22242259
CURRENT_PROJECT_VERSION = 1;
22252260
DEVELOPMENT_TEAM = R63EM248DP;
@@ -2229,6 +2264,7 @@
22292264
PRODUCT_NAME = "$(TARGET_NAME)";
22302265
SWIFT_COMPILATION_MODE = wholemodule;
22312266
SWIFT_EMIT_LOC_STRINGS = NO;
2267+
SWIFT_OBJC_BRIDGING_HEADER = "Sources/BranchSDK/TestHostUITests-Bridging-Header.h";
22322268
SWIFT_OPTIMIZATION_LEVEL = "-O";
22332269
SWIFT_VERSION = 5.0;
22342270
TARGETED_DEVICE_FAMILY = "1,2";

‎Sources/BranchSDK/BNCConfig.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include "BNCConfig.h"
1010

11-
NSString * const BNC_SDK_VERSION = @"3.12.1";
11+
NSString * const BNC_SDK_VERSION = @"3.12.2";
1212
NSString * const BNC_LINK_URL = @"https://bnc.lt";
1313
NSString * const BNC_CDN_URL = @"https://cdn.branch.io";
1414

‎Sources/BranchSDK/BNCRequestFactory.m‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
#import "BNCReferringURLUtility.h"
3636
#import "BNCPasteboard.h"
3737
#import "BNCODMInfoCollector.h"
38+
#import "BranchConfigurationController.h"
3839

3940
@interface BNCRequestFactory()
4041

@@ -135,6 +136,9 @@ - (NSDictionary *)dataForInstallWithURLString:(NSString *)urlString {
135136

136137
// Add Enhanced Web UX params
137138
[self addWebUXParams:json];
139+
140+
// Add Operation Metrics for Install only.
141+
[self addOperationalMetrics:json];
138142

139143
return json;
140144
}
@@ -386,7 +390,7 @@ - (void)addDMAConsentParamsToJSON:(NSMutableDictionary *)json {
386390
if([self.preferenceHelper eeaRegionInitialized]){
387391
[self safeSetValue:@([self.preferenceHelper eeaRegion]) forKey:BRANCH_REQUEST_KEY_DMA_EEA onDict:json];
388392
[self safeSetValue:@([self.preferenceHelper adPersonalizationConsent]) forKey:BRANCH_REQUEST_KEY_DMA_AD_PEROSALIZATION onDict:json];
389-
[self safeSetValue:@([self.preferenceHelper adUserDataUsageConsent]) forKey:BRANCH_REQUEST_KEY_DMA_AD_USER_DATA onDict:json];
393+
[self safeSetValue:@([self.preferenceHelper adUserDataUsageConsent]) forKey:BRANCH_REQUEST_KEY_DMA_AD_USER_DATA onDict:json];
390394
}
391395
}
392396

@@ -425,6 +429,12 @@ - (void)addLocalURLToOpenJSON:(NSMutableDictionary *)json {
425429
}
426430
}
427431

432+
// If the client uses a UIPasteControl, force a new open to fetch the payload
433+
- (void)addOperationalMetrics:(NSMutableDictionary *)json {
434+
[self safeSetValue:[[BranchConfigurationController sharedInstance] getConfiguration] forKey:BRANCH_REQUEST_KEY_OPERATIONAL_METRICS onDict:json];
435+
}
436+
437+
428438
- (void)clearLocalURLFromStorage {
429439
self.preferenceHelper.localUrl = nil;
430440
#if !TARGET_OS_TV

‎Sources/BranchSDK/BNCServerAPI.m‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,20 @@ - (NSString *)customEventServiceURL{
5252
}
5353

5454
- (NSString *)linkServiceURL {
55-
return [[self getBaseURLForLinkingEndpoints] stringByAppendingString: @"/v1/url"];
55+
return [[self getBaseURLForLinkingEndpoints:YES] stringByAppendingString: @"/v1/url"];
5656
}
5757

5858
- (NSString *)qrcodeServiceURL {
59-
return [[self getBaseURLForLinkingEndpoints] stringByAppendingString: @"/v1/qr-code"];
59+
return [[self getBaseURLForLinkingEndpoints:YES] stringByAppendingString: @"/v1/qr-code"];
6060
}
6161

6262
// LATD endpoint is not a data collection endpoint and will be treated like linking endpoints
6363
- (NSString *)latdServiceURL {
64-
return [[self getBaseURLForLinkingEndpoints] stringByAppendingString: @"/v1/cpid/latd"];
64+
return [[self getBaseURLForLinkingEndpoints:YES] stringByAppendingString: @"/v1/cpid/latd"];
6565
}
6666

6767
- (NSString *)validationServiceURL {
68-
return [[self getBaseURLForLinkingEndpoints] stringByAppendingString: @"/v1/app-link-settings"];
68+
return [[self getBaseURLForLinkingEndpoints:NO] stringByAppendingString: @"/v1/app-link-settings"];
6969
}
7070

7171
// Currently we switch to tracking domains if we detect IDFA, indicating that Ad Tracking is enabled
@@ -78,8 +78,9 @@ - (BOOL)optedIntoIDFA {
7878
}
7979

8080
// Linking endpoints are not used for Ads tracking
81-
- (NSString *)getBaseURLForLinkingEndpoints {
82-
if (self.customAPIURL) {
81+
- (NSString *)getBaseURLForLinkingEndpoints:(BOOL)useCustomURL {
82+
// Determines whether to use custom API URL (when available) or always use standard URL
83+
if (useCustomURL && self.customAPIURL) {
8384
return self.customAPIURL;
8485
}
8586

‎Sources/BranchSDK/BNCServerInterface.m‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,24 @@ - (void)genericHTTPRequest:(NSURLRequest *)request retryNumber:(NSInteger)retryN
148148
NSError *error = [NSError branchErrorWithCode:BNCVPNAdBlockerError];
149149
[[BranchLogger shared] logError:[NSString stringWithFormat:@"Possible VPN Ad Blocker. Giving up on request with HTTP status code %ld. Underlying error: %@", (long)status, underlyingError] error:error];
150150
} else {
151-
[[BranchLogger shared] logWarning: [NSString stringWithFormat:@"Giving up on request with HTTP status code %ld", (long)status] error:underlyingError];
151+
// If a network request is successful, the `data` field will be populated with the error response from the service
152+
// We have to create an NSError object here to pass down to callback.
153+
154+
if(serverResponse.data && serverResponse.data[@"error"] != nil){
155+
id errorJson = serverResponse.data[@"error"];
156+
157+
if(errorJson[@"message"] != nil){
158+
NSString *errorString = errorJson[@"message"];
159+
NSDictionary *userInfo = @{
160+
NSLocalizedDescriptionKey: errorString,
161+
};
162+
underlyingError = [NSError errorWithDomain:[NSError bncErrorDomain]
163+
code:[(errorJson[@"code"]) integerValue]
164+
userInfo:userInfo];
165+
}
166+
}
167+
168+
[[BranchLogger shared] logError: [NSString stringWithFormat:@"Giving up on request with HTTP status code %ld", (long)status] error:underlyingError];
152169
}
153170
}
154171

@@ -244,7 +261,7 @@ - (BNCServerResponse *)genericHTTPRequestSynchronous:(NSURLRequest *)request {
244261
serverResponse =
245262
[self processServerResponse:operation.response
246263
data:operation.responseData error:operation.error];
247-
[self collectInstrumentationMetricsWithOperation:operation];
264+
[self collectInstrumentationMetricsWithOperation:operation];
248265
dispatch_semaphore_signal(semaphore);
249266
}];
250267
[operation start];

0 commit comments

Comments
 (0)