Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Confusion regarding default tool title and description. #47

Open
AdamRobertson-Cognasim opened this issue Dec 20, 2024 · 2 comments

Comments

@AdamRobertson-Cognasim
Copy link

I'm enjoying working with your framework so far! It is very helpful.

Small question however: Why is the default title and descriptions for tools based on the input schema? Asking because I want to make sure I'm understanding the motivation so I can take advantage of it.

Is this so that a tool can have multiple uses by changing what input_schema is being used in config?
If that's so, then isn't it less confusing to just change the description from config? And have the tools run function accept a Union of all acceptable schemas?

Having it default to the input schemas caught me by surprise and seems unintuitive.

@KennyVaneetvelde
Copy link
Member

@AdamRobertson-Cognasim

You are correct in your assumption of its usage, but incorrect in your assumption of how it works 😅 But to be fair this is probably the only thing in the framework I didn't obsessively over-think... Mostly because I couldn't envision many clear use cases, so I'm open to ideas and scenarios on how you want to be using this!

Anyways, if you look closely at the code of base_tool.py you will see that in fact you can change the description from the config, and it is in fact the default. The title & description in the input schema are a fallback. Looking at it know, maybe it makes sense to only have it in the config...

But for now, I'd say use whatever way makes most sense to you and stick by it...

For now, I won't change anything but leave this issue open in case anyone wants to join in with some input

@AdamRobertson-Cognasim
Copy link
Author

Ok! Just curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants