Object disposed instead of crash, hell yeah.

Author: Bobris

BTDB/KVDBLayer/Implementation/BTreeKeyValueDBCursor.cs

@@ -91,20 +91,26 @@ public void Dispose()
 
     public bool FindFirstKey(in ReadOnlySpan<byte> prefix)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         _modifiedFromLastFind = false;
         _keyIndex = -1;
         return _cursor!.FindFirst(prefix);
     }
 
     public bool FindLastKey(in ReadOnlySpan<byte> prefix)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         _modifiedFromLastFind = false;
         _keyIndex = _cursor!.FindLastWithPrefix(prefix);
         return _keyIndex >= 0;
     }
 
     public bool FindPreviousKey(in ReadOnlySpan<byte> prefix)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         if (_modifiedFromLastFind)
         {
             if (FindKeyIndex(_keyIndex - 1) && _cursor!.KeyHasPrefix(prefix))
@@ -132,6 +138,8 @@ public bool FindPreviousKey(in ReadOnlySpan<byte> prefix)
 
     public bool FindNextKey(in ReadOnlySpan<byte> prefix)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         if (_modifiedFromLastFind)
         {
             if (!_removedCurrent) _keyIndex++;
@@ -160,6 +168,8 @@ public bool FindNextKey(in ReadOnlySpan<byte> prefix)
 
     public FindResult Find(in ReadOnlySpan<byte> key, uint prefixLen)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         _modifiedFromLastFind = false;
         var result = _cursor!.Find(key);
         _keyIndex = -1;
@@ -203,6 +213,8 @@ public long GetKeyIndex()
 
     public bool FindKeyIndex(in ReadOnlySpan<byte> prefix, long index)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         _modifiedFromLastFind = false;
         if (!_cursor!.FindFirst(prefix))
         {
@@ -225,6 +237,8 @@ public bool FindKeyIndex(in ReadOnlySpan<byte> prefix, long index)
 
     public bool FindKeyIndex(long index)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         _modifiedFromLastFind = false;
         _keyIndex = -1;
         if (_cursor!.SeekIndex(index))
@@ -269,16 +283,22 @@ public KeyValuePair<uint, uint> GetStorageSizeOfCurrentKey()
 
     public ReadOnlyMemory<byte> GetKeyMemory(ref Memory<byte> buffer, bool copy = false)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         return _cursor!.GetKeyMemory(ref buffer, copy);
     }
 
     public ReadOnlySpan<byte> GetKeySpan(scoped ref Span<byte> buffer, bool copy = false)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         return _cursor!.GetKeySpan(ref buffer, copy);
     }
 
     public ReadOnlySpan<byte> GetKeySpan(Span<byte> buffer, bool copy = false)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         return _cursor!.GetKeySpan(buffer, copy);
     }
 
@@ -291,6 +311,8 @@ public bool IsValueCorrupted()
 
     public ReadOnlyMemory<byte> GetValueMemory(ref Memory<byte> buffer, bool copy = false)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         if (!IsValid()) return new();
         var trueValue = _cursor!.GetValue();
         var keyValueDB = _transaction!.KeyValueDB;
@@ -319,6 +341,8 @@ public ReadOnlyMemory<byte> GetValueMemory(ref Memory<byte> buffer, bool copy =
 
     public ReadOnlySpan<byte> GetValueSpan(scoped ref Span<byte> buffer, bool copy = false)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         if (!IsValid()) return new();
         var trueValue = _cursor!.GetValue();
         var keyValueDB = _transaction!.KeyValueDB;
@@ -360,6 +384,8 @@ void EnsureValidKey()
 
     void EnsureValidCursor()
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         if (!_cursor!.IsValid())
         {
             if (_modifiedFromLastFind && _keyIndex != -1)
@@ -456,6 +482,8 @@ public long EraseUpTo(IKeyValueDBCursor to)
     [SkipLocalsInit]
     public bool CreateOrUpdateKeyValue(in ReadOnlySpan<byte> key, in ReadOnlySpan<byte> value)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         var cursor = (IKeyValueDBCursorInternal)_transaction!.FirstCursor;
         while (cursor != null)
         {
@@ -491,6 +519,8 @@ public bool CreateOrUpdateKeyValue(in ReadOnlySpan<byte> key, in ReadOnlySpan<by
 
     public UpdateKeySuffixResult UpdateKeySuffix(in ReadOnlySpan<byte> key, uint prefixLen)
     {
+        ObjectDisposedException.ThrowIf(_transaction == null, this);
+        ObjectDisposedException.ThrowIf(_transaction.BTreeRoot == null, _transaction);
         var cursor = (IKeyValueDBCursorInternal)_transaction!.FirstCursor;
         while (cursor != null)
         {

BTDB/KVDBLayer/Implementation/BTreeKeyValueDBTransaction.cs

@@ -35,6 +35,7 @@ public BTreeKeyValueDBTransaction(BTreeKeyValueDB keyValueDB, IRootNode root, bo
 
     public IKeyValueDBCursor CreateCursor()
     {
+        ObjectDisposedException.ThrowIf(BTreeRoot == null, this);
         return BTreeKeyValueDBCursor.Create(this);
     }
 
@@ -70,7 +71,8 @@ internal void MakeWritable()
 
     public long GetKeyValueCount()
     {
-        return BTreeRoot!.GetCount();
+        ObjectDisposedException.ThrowIf(BTreeRoot == null, this);
+        return BTreeRoot.GetCount();
     }
 
     public bool IsWriting()
@@ -172,6 +174,7 @@ public ulong GetUlong(uint idx)
 
     public void SetUlong(uint idx, ulong value)
     {
+        ObjectDisposedException.ThrowIf(BTreeRoot == null, this);
         if (BTreeRoot!.GetUlong(idx) != value)
         {
             MakeWritable();
@@ -202,8 +205,9 @@ public string? DescriptionForLeaks
 
     public Dictionary<(uint Depth, uint Children), uint> CalcBTreeStats()
     {
+        ObjectDisposedException.ThrowIf(BTreeRoot == null, this);
         var stats = new RefDictionary<(uint Depth, uint Children), uint>();
-        BTreeRoot!.CalcBTreeStats(stats, 0);
+        BTreeRoot.CalcBTreeStats(stats, 0);
         return stats.ToDictionary(kv => kv.Key, kv => kv.Value);
     }