Revert int Position back to uint Position

Author: Bobris

BTDB.SourceGenerator.Test/BTDB.SourceGenerator.Tests.csproj

@@ -15,9 +15,9 @@
         <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.11.0"/>
         <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0"/>
         <PackageReference Include="Verify.SourceGenerators" Version="2.5.0"/>
-        <PackageReference Include="Verify.Xunit" Version="28.4.0"/>
+        <PackageReference Include="Verify.Xunit" Version="28.8.1"/>
         <PackageReference Include="xunit" Version="2.9.2"/>
-        <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>

BTDB/ODBLayer/IOrderedDictionary.cs

@@ -12,7 +12,7 @@ public interface IOrderedDictionaryEnumerator<TKey, TValue> : IDisposable
     /// <returns>true if there was new key read</returns>
     bool NextKey(out TKey key);
 
-    int Position { get; set; }
+    uint Position { get; set; }
     uint Count { get; }
     TValue CurrentValue { get; set; }
 }

BTDB/ODBLayer/ODBDictionary.cs

@@ -740,19 +740,19 @@ public TValue CurrentValue
             }
         }
 
-        public int Position
+        public uint Position
         {
             get
             {
-                if (_cursor == null) return -1;
-                return (int)(_ascending
+                if (_cursor == null) return 0;
+                return (uint)(_ascending
                     ? _cursor.GetKeyIndex() - _startCursor!.GetKeyIndex()
                     : _endCursor!.GetKeyIndex() - _cursor.GetKeyIndex());
             }
 
             set
             {
-                if ((uint)value >= Count)
+                if (value >= Count)
                 {
                     _cursor?.Dispose();
                     _cursor = null;

BTDB/ODBLayer/RelationEnumerator.cs

@@ -1071,19 +1071,19 @@ public TValue CurrentValue
         set => throw new NotSupportedException();
     }
 
-    public int Position
+    public uint Position
     {
         get
         {
             if (_cursor == null) return 0;
-            return (int)(_ascending
+            return (uint)(_ascending
                 ? _cursor.GetKeyIndex() - _startCursor!.GetKeyIndex()
                 : _endCursor!.GetKeyIndex() - _cursor.GetKeyIndex());
         }
 
         set
         {
-            if ((uint)value >= Count) throw new IndexOutOfRangeException();
+            if (value >= Count) throw new IndexOutOfRangeException();
             if (_ascending)
             {
                 _cursor!.FindKeyIndex(_startCursor!.GetKeyIndex() + value);

BTDBTest/ObjectDBTest.cs

@@ -2302,7 +2302,7 @@ public void AdvancedIterationBasics(int start, bool includeStart, int end, bool
             }
 
             Assert.Equal(result, res);
-            Assert.Equal(-1, (int)e.Position);
+            Assert.Equal(0, (int)e.Count);
             param = new AdvancedEnumeratorParam<int>(EnumerationOrder.Descending, start,
                 start == -1
                     ? KeyProposition.Ignored
@@ -2317,14 +2317,14 @@ public void AdvancedIterationBasics(int start, bool includeStart, int end, bool
             Assert.Equal(result.Length, (int)e2.Count);
             while (e2.NextKey(out key))
             {
-                Assert.Equal(res.Length, e2.Position);
+                Assert.Equal(res.Length, (int)e2.Position);
                 var val = e2.CurrentValue;
                 Assert.Equal(key.ToString(CultureInfo.InvariantCulture), val);
                 res = val + res;
             }
 
             Assert.Equal(result, res);
-            Assert.Equal(-1, e2.Position);
+            Assert.Equal(0u, e2.Position);
         }
     }
 
@@ -2377,7 +2377,7 @@ public void AdvancedIterationSeeks(int start, bool includeStart, int end, bool i
             e.Position = 2;
             while (e.NextKey(out key))
             {
-                Assert.Equal(res.Length, e.Position - 2);
+                Assert.Equal(res.Length, (int)e.Position - 2);
                 var val = e.CurrentValue;
                 Assert.Equal(key.ToString(CultureInfo.InvariantCulture), val);
                 res += val;