another round of new clippy lints #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would warn about some subset of index-related panics. In recent nightlies this has been subsumed by the `indexing_slicing` lint which lints on all array indexing. This is pretty cool but waay overkill.
This is mostly a style thing.
As a matter of style, we should always have items (structs, fns, etc) first in a block before any real code. This is because it's easy for the real code to be missed if it's interspersed with items.
Style thing.
Ok, this one might be controversial :). Purely stylistic. Uses the new `let...else` syntax. Saves a line of code.
Style. This one looks a bit scary because it's not obvious what the right order of parameters to `map_or` is, but actually it's fine -- the first parameter is an object and the second is a function, and they only look the same because of Rust's pattern syntax.
apoelstra
force-pushed
the
2025-05--clippy-2
branch
from
47f039b to
0fc8f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly style. Does find one real issue with our docs.