clippy: turn on manual_assert lint

Style thing.

Author: apoelstra

Cargo.toml

@@ -99,7 +99,7 @@ large_stack_arrays = "warn"
 large_types_passed_by_value = "warn"
 linkedlist = "warn"
 macro_use_imports = "warn"
-manual_assert = "allow"
+manual_assert = "warn"
 manual_instant_elapsed = "warn"
 manual_is_power_of_two = "warn"
 manual_is_variant_and = "warn"

src/error.rs

@@ -35,14 +35,11 @@ impl Position {
     ///
     /// Line or column are zero.
     pub const fn new(line: usize, col: usize) -> Self {
-        if line == 0 {
-            panic!("Line must not be zero");
-        }
+        // assert_ne not available in constfn
+        assert!(line != 0, "line must not be zero",);
         // Safety: Checked above
         let line = unsafe { NonZeroUsize::new_unchecked(line) };
-        if col == 0 {
-            panic!("Column must not be zero");
-        }
+        assert!(col != 0, "column must not be zero",);
         // Safety: Checked above
         let col = unsafe { NonZeroUsize::new_unchecked(col) };
         Self { line, col }

src/lib.rs

@@ -620,9 +620,10 @@ fn main() {
         ) {
             Ok(_) => panic!("Accepted faulty program"),
             Err(error) => {
-                if !error.contains("Expected expression of type `bool`, found type `()`") {
-                    panic!("Unexpected error: {error}")
-                }
+                assert!(
+                    error.contains("Expected expression of type `bool`, found type `()`"),
+                    "Unexpected error: {error}",
+                );
             }
         }
     }