Skip to content

Commit 8e15fd3

Browse files
committed
clippy: invert != in if statements
This is a stylistic lint which you could argue either way, but I like having it on for consistency.
1 parent 3fdacb5 commit 8e15fd3

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ flat_map_option = "warn"
7777
float_cmp = "warn"
7878
fn_params_excessive_bools = "warn"
7979
from_iter_instead_of_collect = "warn"
80-
if_not_else = "allow"
80+
if_not_else = "warn"
8181
ignored_unit_patterns = "allow"
8282
implicit_clone = "warn"
8383
implicit_hasher = "warn"

src/ast.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -1039,27 +1039,27 @@ impl AbstractSyntaxTree for Call {
10391039
parse_args: &[parse::Expression],
10401040
expected_tys: &[ResolvedType],
10411041
) -> Result<(), Error> {
1042-
if parse_args.len() != expected_tys.len() {
1042+
if parse_args.len() == expected_tys.len() {
1043+
Ok(())
1044+
} else {
10431045
Err(Error::InvalidNumberOfArguments(
10441046
expected_tys.len(),
10451047
parse_args.len(),
10461048
))
1047-
} else {
1048-
Ok(())
10491049
}
10501050
}
10511051

10521052
fn check_output_type(
10531053
observed_ty: &ResolvedType,
10541054
expected_ty: &ResolvedType,
10551055
) -> Result<(), Error> {
1056-
if observed_ty != expected_ty {
1056+
if observed_ty == expected_ty {
1057+
Ok(())
1058+
} else {
10571059
Err(Error::ExpressionTypeMismatch(
10581060
expected_ty.clone(),
10591061
observed_ty.clone(),
10601062
))
1061-
} else {
1062-
Ok(())
10631063
}
10641064
}
10651065

0 commit comments

Comments
 (0)