Skip to content

Commit edcba04

Browse files
committed
Merge #231: musig: add note about missing verification to partial_sign to doc
4ab4ec3 musig: add note about missing verification to partial_sign to doc (Jonas Nick) f50ad76 musig: update version number of BIP (Jonas Nick) Pull request description: ACKs for top commit: real-or-random: ACK 4ab4ec3 Tree-SHA512: 1e35d83dd97bac96dfbc02d58841582afe67c38562c728bc3c593a797e1316dfdd550c4988dc78557f25a1633711ec13b35f6c5bae0f7dd29c9f1c994ad5c82c
2 parents 4eab2c2 + 4ab4ec3 commit edcba04

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

include/secp256k1_musig.h

+10-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ extern "C" {
99

1010
#include <stddef.h>
1111

12-
/** This module implements BIP MuSig2 v1.0.0-rc.3, a multi-signature scheme
13-
* compatible with BIP-340 ("Schnorr"). You can find an example demonstrating
14-
* the musig module in examples/musig.c.
12+
/** This module implements BIP 327 "MuSig2 for BIP340-compatible
13+
* Multi-Signatures"
14+
* (https://github.com/bitcoin/bips/blob/master/bip-0327.mediawiki)
15+
* v1.0.0. You can find an example demonstrating the musig module in
16+
* examples/musig.c.
1517
*
1618
* The module also supports BIP-341 ("Taproot") public key tweaking and adaptor
1719
* signatures as described in
@@ -440,6 +442,11 @@ SECP256K1_API SECP256K1_WARN_UNUSED_RESULT int secp256k1_musig_nonce_process(
440442
* created by calling musig_nonce_gen with that pubkey. Otherwise, the
441443
* illegal_callback is called.
442444
*
445+
* This function does not verify the output partial signature, deviating from
446+
* the BIP 327 specification. It is recommended to verify the output partial
447+
* signature with `secp256k1_musig_partial_sig_verify` to prevent random or
448+
* adversarially provoked computation errors.
449+
*
443450
* Returns: 0 if the arguments are invalid or the provided secnonce has already
444451
* been used for signing, 1 otherwise
445452
* Args: ctx: pointer to a context object

0 commit comments

Comments
 (0)