Hacspec Halfagg: Match BIP340 challenge input to BIP

fjahr · fjahr · commit 544f123e390b · 2024-01-31T14:37:48.000+01:00
diff --git a/hacspec-halfagg/src/halfagg.rs b/hacspec-halfagg/src/halfagg.rs
@@ -120,7 +120,7 @@ pub fn verify_aggregate(aggsig: &AggSig, pm_aggd: &Seq<(PublicKey, Message)>) ->
             VerifyResult::Err(Error::InvalidSignature)?;
         }
         let r = r_res.unwrap();
-        let e = scalar_from_bytes(hash_challenge(rx, bytes_from_point(p), msg));
+        let e = scalar_from_bytes(hash_challenge(rx, pk, msg));
         pmr[i] = (pk, msg, rx);
         let z = randomizer(&pmr, i);
         terms[2 * i] = (z, r);

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ pub fn verify_aggregate(aggsig: &AggSig, pm_aggd: &Seq<(PublicKey, Message)>) ->`
`120`	`120`	`VerifyResult::Err(Error::InvalidSignature)?;`
`121`	`121`	`}`
`122`	`122`	`let r = r_res.unwrap();`
`123`		`- let e = scalar_from_bytes(hash_challenge(rx, bytes_from_point(p), msg));`
	`123`	`+ let e = scalar_from_bytes(hash_challenge(rx, pk, msg));`
`124`	`124`	`pmr[i] = (pk, msg, rx);`
`125`	`125`	`let z = randomizer(&pmr, i);`
`126`	`126`	`terms[2 * i] = (z, r);`