Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No id parameter in GroupModel contructor #496

Open
vitorlinares opened this issue Jan 10, 2025 · 0 comments
Open

No id parameter in GroupModel contructor #496

vitorlinares opened this issue Jan 10, 2025 · 0 comments

Comments

@vitorlinares
Copy link

Hello,

Just would like to understand if there is any particular reason to do not have an overload of the GroupModel constructor accepting the id as parameter.
If you serialize the diagram nodes in a Json format , when recreating the diagram from the json payload you need to create additional logic to update the id of the groups in all child elements in your Json and refactor all the links based in the new id.
That's additional processing time that could be avoided by just allowing us to set the Id of the GroupModel when instantiating it from Json.

If there is no particular reason for that, could we have this added in the next release?
I don't think it will be a big change, since the GroupModel inherits from NodeModel, which already have the id parameter in the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant