TransitUIWebViewContext must keep original delegate weak

[HBehrens]

Transit/source/objc/Transit.m

Line 1656 in b5b738b

id<UIWebViewDelegate> _originalDelegate;

[mrcljx]

// ObjC novice speaking here

Are you sure about that? Strong seems fine to me because nothing else would be referencing it. Maybe the app forgot to set webView.delegate = nil which would release the TransitUIWebViewContext which would release the _originalDelegate then?

Or am I missing something?

[HBehrens]

before: webView held delegate weakly
after: transitContext holds delegate strong

In common scenarios, the delegate (e.g. a ViewController) holds the transitContext strong so a retain cycle occurs.

[mrcljx]

Hmm, okay. Based on the UIWebView.delegate documentation and the warning I would have guessed that WebView has a strong reference on the delegate (although the property is "assign").

Important: Before releasing an instance of UIWebView for which you have set a delegate, you must first set its delegate property to nil. This can be done, for example, in your dealloc method.