Skip to content

Commit 8b6d709

Browse files
committed
Rename 'kinematics-only' to 'base-sim-only' in docs and test names
Terminology cleanup to match how skip_process_dynamics is described elsewhere; the env wraps the full base sim, not just kinematics.
1 parent e82df9d commit 8b6d709

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

predicators/code_sim_learning/training.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def fit_params(
371371
372372
Args:
373373
simulator_fn: Simulator(state, action, params_dict) -> updates.
374-
Should run kinematics internally if needed.
374+
Should run the base sim internally if needed.
375375
transitions: List of (s_t, action, s_{t+1}_obs) triples.
376376
param_specs: Parameter specifications (name, init_value).
377377
process_features: {type_name: [feat_names]} to fit.

tests/approaches/test_agent_sim_learning_approach.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@ def _build_kinematics_only_oracle(env):
8181

8282

8383
def _build_combined_model(env):
84-
"""Build a combined model: kinematics-only env + GT step-level dynamics.
84+
"""Build a combined model: base-sim-only env + GT step-level dynamics.
8585
8686
Mirrors AgentSimLearningApproach: wraps GT rules in a
87-
LearnedSimulator via apply_rules and composes with a kinematics-only
88-
base env.
87+
LearnedSimulator via apply_rules and composes with a base-sim-only
88+
env.
8989
"""
9090
base_env = create_new_env("pybullet_boil",
9191
do_cache=False,

0 commit comments

Comments
 (0)