Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation doesn't appear if I don't refresh the home page #1648

Open
kodjima33 opened this issue Jan 7, 2025 · 2 comments
Open

Conversation doesn't appear if I don't refresh the home page #1648

kodjima33 opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kodjima33
Copy link
Collaborator

kodjima33 commented Jan 7, 2025

Problem: Conversation doesn't appear if I don't refresh the home page.

Cause ? The current conversations discard filter is happened on the local not remote.

Solution: Use the remote discard filter - via api - for the conversations pages.

Implementation:

  1. backend GET /memories, add support ?discard=true/false ~ including discarded conversations or not, default true
    2.backend GET memories/search, add support ?discard=true/false ~ including discarded conversations or not, default true
  2. app add the param discard whenever requesting to 1,2

Image

@kodjima33 kodjima33 moved this to To do in omi TODO Jan 7, 2025
@beastoin beastoin added the bug Something isn't working label Jan 7, 2025
@beastoin beastoin removed the status in omi TODO Jan 7, 2025
@beastoin beastoin moved this to To do in omi TODO Jan 14, 2025
@beastoin beastoin self-assigned this Jan 14, 2025
@beastoin beastoin moved this from To do to In progress in omi TODO Jan 14, 2025
@beastoin
Copy link
Collaborator

solution: use the remote filter, via api, instead of local filter for the discard filter.

@beastoin beastoin moved this from In progress to In review in omi TODO Jan 14, 2025
beastoin added a commit that referenced this issue Jan 14, 2025
@beastoin
Copy link
Collaborator

hey bro, fixed in +209. pls try it and lmk.

moved the discarded convos filtering logic to backend. no more akward behavior on the app.

@kodjima33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In review
Development

No branches or pull requests

2 participants