allow to disable router matching cache + perf improvements

Author: jkyberneees

lib/router/sequential.js

@@ -12,7 +12,9 @@ module.exports = (config = {}) => {
     res.statusCode = 500
     res.end(err.message)
   })
-  config.cacheSize = config.cacheSize || 1000
+  if (config.cacheSize === undefined) {
+    config.cacheSize = 1000
+  }
   config.id = config.id || (Date.now().toString(36) + Math.random().toString(36).substr(2, 5)).toUpperCase()
 
   const routers = {}
@@ -39,15 +41,29 @@ module.exports = (config = {}) => {
   }
 
   router.lookup = (req, res, step) => {
-    req.url = req.url || '/'
-    req.originalUrl = req.originalUrl || req.url
-    req.path = req.url.split('?')[0]
+    if (!req.url) {
+      req.url = '/'
+    }
+    if (!req.originalUrl) {
+      req.originalUrl = req.url
+    }
+    const varsIndex = req.url.indexOf('?')
+    if (varsIndex > 0) {
+      req.path = req.url.slice(0, varsIndex)
+    } else {
+      req.path = req.url
+    }
 
-    const reqCacheKey = `${req.method + req.path}`
-    let match = cache.get(reqCacheKey)
-    if (!match) {
+    let match
+    if (config.cacheSize > 0) {
+      const reqCacheKey = `${req.method + req.path}`
+      match = cache.get(reqCacheKey)
+      if (!match) {
+        match = router.find(req.method, req.path)
+        cache.set(reqCacheKey, match)
+      }
+    } else {
       match = router.find(req.method, req.path)
-      cache.set(reqCacheKey, match)
     }
 
     if (match.handlers.length) {
@@ -66,7 +82,10 @@ module.exports = (config = {}) => {
       }
 
       // middlewares invocation
-      req.params = Object.assign(req.params || {}, match.params)
+      if (!req.params) {
+        req.params = {}
+      }
+      req.params = Object.assign(req.params, match.params)
 
       return next(middlewares, req, res, 0, routers, config.defaultRoute, config.errorHandler)
     } else {