Correct and test fusion module in RZ geometry #3255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Contributor
|
This pull request introduces 1 alert when merging e85d2c5 into afda3a4 - view on LGTM.com new alerts:
|
Contributor
|
This pull request introduces 1 alert when merging f1994ea into 47eef0b - view on LGTM.com new alerts:
|
Contributor
|
This pull request introduces 1 alert when merging 422586b into 47eef0b - view on LGTM.com new alerts:
|
RemiLehe
changed the title
RemiLehe
changed the title
Contributor
|
This pull request introduces 1 alert when merging 337b2ed into 3bf1a33 - view on LGTM.com new alerts:
|
RemiLehe
commented
Sep 19, 2022
| check_isotropy(data, relative_tolerance = 3.e-2) | ||
| def specific_check1(data, dt): | ||
| if not is_RZ: | ||
| check_isotropy(data, relative_tolerance = 3.e-2) |
Member
Author
There was a problem hiding this comment.
We don't check for isotropy in the RZ case, since the distribution of momentum for the products is not yet correct.
Contributor
|
This pull request introduces 1 alert when merging 70a864e into 6e75516 - view on LGTM.com new alerts:
|
EZoni
reviewed
Sep 19, 2022
Member
EZoni
left a comment
EZoni
left a comment
There was a problem hiding this comment.
Thank you for this PR, Remi! Looks good to me, I just left a couple of minor comments.
Comment on lines
69
to
71
| ## Checks whether this is the 2D or the 3D test | ||
| is_RZ = "RZ" in sys.argv[1] | ||
|
|
Member
There was a problem hiding this comment.
One other way to do this (which I personally find a little more robust, because it does not rely on the test's name) is to parse the output file warpx_used_inputs and determine the geometry from there:
warpx_used_inputs = open('./warpx_used_inputs', 'r').read()
if re.search('geometry.dims = 2', warpx_used_inputs):
is_RZ = False
elif re.search('geometry.dims = RZ', warpx_used_inputs):
is_RZ = True
Regression/WarpX-tests.ini
Outdated
| useMPI = 1 | ||
| numprocs = 2 | ||
| useOMP = 1 | ||
| numthreads = 2 |
Member
There was a problem hiding this comment.
I think this needs to be maximum 1 if numprocs = 2:
Suggested change
| numthreads = 2 | |
| numthreads = 1 |
Contributor
|
This pull request introduces 1 alert when merging 65b43eb into 5e17906 - view on LGTM.com new alerts:
|
Contributor
|
This pull request introduces 1 alert when merging d399ac2 into 5e17906 - view on LGTM.com new alerts:
|
EZoni
approved these changes
Sep 20, 2022
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 22, 2022
* Add particle rotation in NuclearFusionFunc.H * Minor * indent * initial work * fixed bugs and added species * update documentation * delete unused file * Add properties for neutron, hydrogen isotopes, helium isotopes * Update code to be more consistent * Correct typo * Parse deuterium-tritium fusion * Start putting in place the files for deuterium-tritium * Update documentation * Prepare structures for deuterium tritium * Fix typo * Fix compilation * Add neutron * Add correct formula for the cross-section * Correct compilation error * Fix nuclear fusion * Reset benchmarks * Prepare creation functor for 2-product fusion * First implementation of momentum initialization * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Use utility function for fusion * Minor modification of variable names * Fix GPU compilation * Fix single precision compilation * Update types * Use util function in P-B fusion * Correct compilation errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct errors * Update values of mass and charge * Correct compilation error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct compilation error * Correct compilation error * Correct compilation error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reset benchmark * Use helium particle in proton-boron, to avoid resetting benchmark * Fixed proton-boron test * Revert "Fixed proton-boron test" This reverts commit 73c8d9d. * Incorporate Neil's recommendations * Reset benchmarks * Correct compilation errors * Add new deuterium tritium automated test * Correct formula of cross-section * Correct cross-section * Improve analysis script * Add test of energy conservation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add test of conservation of momentum * Progress in analysis script * Fix error in the initial energy of the deuterium particles * Add check of isotropy * Clean up the test script * Rewrite p_sq formula in a way to avoids machine-precision negative numbers * Add checksum * Clean up code * Add test for fusion in RZ geometry * Update code to take into account actual timestep * Update RZ test * Update RZ test * Increase number of particles * Impart radial memory on DT particles * Correct RZ momenta * Remove unused file * Update test * Fix definition of theta * Add new test * Add checksum * Update test * Update tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix Python analysis script * Remove CPU and ID from new benchmark Co-authored-by: Yinjian Zhao <[email protected]> Co-authored-by: Luca Fedeli <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RZ geometry, particles need to be temporarily rotated before/after the two-particle fusion event, in order to reflect the cylindrical symmetry of the distribution function for the plasma. (This is similar to what was implemented for the Coulomb collisions: #2510.)
In this PR we implement this rotation, but only for the incident particles (i.e. not yet for the products of the reaction, which will be done in a follow-up PR). As a result the reaction rates and number of particles created will be correct (because the incident have been properly rotated), but the exact momentum distribution of the product species will not. (At least, not before we implement the rotation of the product, in the follow-up PR.)
This PR also adds an RZ test, where particles are initialized with an azimuthal velocity. The test does not check for isotropy in the momentum distribution of the products, because of the above-mentioned limitation for the momentum distribution of the products.