[v5] Add PCAFactory and correlation id optional params to createNestablePublicClientApplication #8093
+345
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the createNestablePublicClientApplication function by adding two optional parameters: correlationId and pcaFactory. The enhancement allows users to provide their own correlation ID instead of auto-generating one and to use a custom factory function for creating the PublicClientApplication instance.
Key changes:
- Added optional
correlationIdparameter to allow custom correlation IDs - Added optional
pcaFactoryparameter to enable custom PCA instance creation - Updated function signature and implementation to handle the new parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/msal-browser/src/app/PublicClientApplication.ts | Updated function signature and implementation to support optional correlationId and pcaFactory parameters |
| lib/msal-browser/test/app/createNestablePublicClientApplication.spec.ts | Added comprehensive test coverage for the new optional parameters including edge cases |
| lib/msal-browser/apiReview/msal-browser.api.md | Updated API documentation to reflect the new function signature |
| change/@azure-msal-browser-e8a7eb79-1f90-43a2-8788-a2e901e835ca.json | Added beachball change file for the minor version update |
sameerag
approved these changes
Oct 13, 2025
konstantin-msft
force-pushed
the
enable_1p_naa
branch
from
8bb118f to
e94f3c6
Compare
hectormmg
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PCAFactory and correlation id optional params to createNestablePublicClientApplication