You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prior to the migration of IMDS logic migration from Azure.Identity, when the IMDS endpoint returned invalid json, the exception thrown was distinguishable from other general failures such that it could be treated as if the IMDS endpoint was unavailable.
In the Azure.Identity implementation, when the response from IMDS cannot be parsed as valid json, a distinct exception is thrown so that we can handle it appropriately.
In the case of MSAL, perhaps a distinct MsalError could be used so that Azure.Identity could handle this in the same way as before to prevent the regression.
The text was updated successfully, but these errors were encountered:
Prior to the migration of IMDS logic migration from Azure.Identity, when the IMDS endpoint returned invalid json, the exception thrown was distinguishable from other general failures such that it could be treated as if the IMDS endpoint was unavailable.
In the MSAL implementation of ImdsManagedIdentitySource.HandleResponseAsync the
MsalError.ManagedIdentityRequestFailed
error code is thrown unconditionally.In the Azure.Identity implementation, when the response from IMDS cannot be parsed as valid json, a distinct exception is thrown so that we can handle it appropriately.
In the case of MSAL, perhaps a distinct MsalError could be used so that Azure.Identity could handle this in the same way as before to prevent the regression.
The text was updated successfully, but these errors were encountered: