Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCGC] Add decorator to represent models-to-treat-empty-string-as-null configuration for csharp emitter #2387

Closed
4 tasks done
live1206 opened this issue Mar 14, 2025 · 3 comments · Fixed by #2441
Closed
4 tasks done
Assignees
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@live1206
Copy link
Member

Clear and concise description of the problem

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/autorest.md

models-to-treat-empty-string-as-null:
  - ManagedClusterSubnet
  - NodeTypeFrontendConfiguration
  - ServiceFabricManagedClusterData
  - ServiceFabricManagedClusterVersion
  - ServiceFabricManagedNodeTypeData
  - VmManagedIdentity

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@live1206 live1206 added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Mar 14, 2025
@tadelesh
Copy link
Member

if it is a language specific behavior, i doubt if it should be a tcgc decorator.

@live1206
Copy link
Member Author

if it is a language specific behavior, i doubt if it should be a tcgc decorator.

Think we had a discussion about this in #1229 already, we put csharp specific decorator in TCGC.

@iscai-msft
Copy link
Contributor

can we talk about this in our dpg sync on wednesday before you guys merge this? Thanks!

github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2025
fix [issue2387](#2387).

---------

Co-authored-by: Haiyuan Zhang <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants