Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 16 actions are deprecated. #97

Open
afifurrohman-id opened this issue Jan 26, 2024 · 8 comments
Open

Node.js 16 actions are deprecated. #97

afifurrohman-id opened this issue Jan 26, 2024 · 8 comments

Comments

@afifurrohman-id
Copy link

afifurrohman-id commented Jan 26, 2024

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: azure/container-apps-deploy-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@afifurrohman-id afifurrohman-id changed the title Node.js 16 actions are deprecated. Node.js 16 actions are deprecated. Jan 26, 2024
@onionhammer
Copy link

onionhammer commented Mar 21, 2024

Is container-apps-deploy-action deprecated?

@Jordan-Afonso-OCC
Copy link

@afifurrohman-id for

azure/login@v1

You must have a step in your workflow which uses this action v1 and you can then replace it with azure/login@v2

If not, check in the Set up job in your workflow if you can find something like :
Getting action download info
Download action repository 'azure/login@v1'

which means that one of your marketplace step that you use in your workflow uses the old version of this action. Try to update it if a new version is available or raise an issue on their repo.

about this :

azure/container-apps-deploy-action@v2

did someone plan to update node version of this action ??

@afifurrohman-id
Copy link
Author

You must have a step in your workflow which uses this action v1 and you can then replace it with azure/login@v2

Thank you fyi, i didn't check if azure-login have v2.

@yevhenii0bozhenko
Copy link

Dear team,
Could you please have a look at this line:

using: 'node16'

Looks like it has been forgotten to update.

@afifurrohman-id
Copy link
Author

Dear team, Could you please have a look at this line:

using: 'node16'

Looks like it has been forgotten to update.

It's easy to just update a string, but a significant version changes may contains breaking changes

@yevhenii0bozhenko
Copy link

@afifurrohman-id, it looks like the action is already using node version 20. It is just a description that is not being up to date:

"@types/node": "^20.6.0"

@afifurrohman-id
Copy link
Author

@afifurrohman-id, it looks like the action is already using node version 20. It is just a description that is not being up to date:

"@types/node": "^20.6.0"

That's just a library version, the problem itself not about the library, but the runtime itself.

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

@cf-rdegregory
Copy link

Hello @snehapar9 & @cormacpayne, this issue has been open for 10 months now...is there any plan for Microsoft to continue the development and security patching of this Action?

Or has it been abandoned and we should just resort to direct AZ CLI commands to perform these operations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants