Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between readme functionality and actually implemented functionality for arg 'buildArguments' #119

Open
nath3lf opened this issue Dec 30, 2024 · 1 comment

Comments

@nath3lf
Copy link

nath3lf commented Dec 30, 2024

Error Details:

The readme lists the following argument as valid within the confines of a workflow.

buildArguments No A list of build arguments provided as KEY=VALUE pairings and are space-separated. If a Dockerfile has been provided or is discovered in the application source, each build argument will be passed to the docker build command via the --build-arg flag. If the Oryx++ builder is used to create a runnable application image, each build argument will be passed to the pack build command via the --env flag.

When I use the workflow file like below, the workflow is invalid. Upon examining the workflow action.yaml - this input is not even supported.

  - name: Build and deploy Container App
    uses: azure/container-apps-deploy-action@v1
    with:
      ...
      buildArguments: |
        "IMAGE_SHA_ARG=${{ env.IMAGE_SHA }}"
@bjarkehs
Copy link

In case other people also run into this issue. The docs mention buildArguments but it's only supported in v2. If you change:

uses: azure/container-apps-deploy-action@v1

to

uses: azure/container-apps-deploy-action@v2

it'll work 👍

Hopefully the PR #114 that clears up this confusion will be merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants