Skip to content

Commit cef61c3

Browse files
authored
Do not use workspace dependency for AMQP, EH (#2595)
Fixes #2551 in a different way since #2574 effectively turns off default features. I successfully ran the following as a test: ```bash eng/scripts/verify-dependencies.rs cargo test -p azure_security_keyvault_secrets cargo +nightly -Zpackage-workspace package --allow-dirty -p typespec -p typespec_client_core -p typespec_macros -p azure_core -p azure_core_amqp -p azure_messaging_eventhubs -p azure_security_keyvault_secrets ``` This proves that `azure_core`'s default features were enabled - specifically the `reqwest_deflate` and `reqwest_gzip` feautres to enable their corresponding headers - and that we could package (and publish) versions this way.
1 parent 5600e0a commit cef61c3

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ path = "sdk/typespec/typespec_macros"
4747
[workspace.dependencies.azure_core]
4848
version = "0.25.0"
4949
path = "sdk/core/azure_core"
50-
default-features = false
5150

5251
[workspace.dependencies.azure_core_amqp]
5352
version = "0.4.0"

sdk/core/azure_core_amqp/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ edition.workspace = true
1919

2020
[dependencies]
2121
async-trait.workspace = true
22-
azure_core = { workspace = true, default-features = false }
22+
azure_core = { path = "../azure_core", version = "0.25.0", default-features = false }
2323
fe2o3-amqp = { workspace = true, optional = true }
2424
fe2o3-amqp-cbs = { workspace = true, optional = true }
2525
fe2o3-amqp-ext = { workspace = true, optional = true }

sdk/eventhubs/azure_messaging_eventhubs/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ edition.workspace = true
2121
async-lock.workspace = true
2222
async-stream.workspace = true
2323
async-trait.workspace = true
24-
azure_core = { workspace = true, default-features = false }
24+
azure_core = { path = "../../core/azure_core", version = "0.25.0", default-features = false }
2525
azure_core_amqp.workspace = true
2626
futures.workspace = true
2727
rand.workspace = true

0 commit comments

Comments
 (0)