Skip to content

Commit 1a49eed

Browse files
authored
Context setters in storage_queues crate (#866)
1 parent 282edaa commit 1a49eed

20 files changed

+34
-21
lines changed

sdk/storage/src/core/clients/storage_client.rs

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,24 +40,6 @@ impl StorageClient {
4040
self.storage_account_client.http_client()
4141
}
4242

43-
fn url_with_segments<'a, I>(mut url: url::Url, segments: I) -> azure_core::Result<url::Url>
44-
where
45-
I: IntoIterator<Item = &'a str>,
46-
{
47-
{
48-
let original_url = url.clone();
49-
let mut segs = url.path_segments_mut().map_err(|_| {
50-
Error::with_message(ErrorKind::DataConversion, || {
51-
format!("failed to parse url path segments. url: {original_url}")
52-
})
53-
})?;
54-
for segment in segments.into_iter() {
55-
segs.push(segment);
56-
}
57-
}
58-
Ok(url)
59-
}
60-
6143
pub fn blob_url_with_segments<'a, I>(&'a self, segments: I) -> azure_core::Result<url::Url>
6244
where
6345
I: IntoIterator<Item = &'a str>,
@@ -107,4 +89,19 @@ impl StorageClient {
10789
.send(context, request, service_type)
10890
.await
10991
}
92+
93+
fn url_with_segments<'a, I>(mut url: url::Url, new_segements: I) -> azure_core::Result<url::Url>
94+
where
95+
I: IntoIterator<Item = &'a str>,
96+
{
97+
let original_url = url.clone();
98+
{
99+
let mut segements = url.path_segments_mut().map_err(|_| {
100+
let message = format!("failed to parse url path segments from '{original_url}'");
101+
Error::message(ErrorKind::DataConversion, message)
102+
})?;
103+
segements.extend(new_segements);
104+
}
105+
Ok(url)
106+
}
110107
}

sdk/storage_queues/src/clients/queue_client.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ impl QueueClient {
8484
}
8585

8686
/// Get the queue metadata.
87-
8887
pub fn get_metadata(&self) -> GetQueueMetadataBuilder {
8988
GetQueueMetadataBuilder::new(self.clone())
9089
}

sdk/storage_queues/src/clients/queue_service_client.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ impl QueueServiceClient {
4141

4242
/// Set queue service properties.
4343
///
44-
/// More info here
45-
/// [https://docs.microsoft.com/rest/api/storageservices/set-queue-service-properties](https://docs.microsoft.com/rest/api/storageservices/set-queue-service-properties).
44+
/// More info here:
45+
/// <https://docs.microsoft.com/rest/api/storageservices/set-queue-service-properties>
4646
pub fn set_queue_service_properties(
4747
&self,
4848
properties: QueueServiceProperties,

sdk/storage_queues/src/operations/clear_messages.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ impl ClearMessagesBuilder {
2121

2222
setters! {
2323
timeout: Timeout => Some(timeout),
24+
context: Context => context,
2425
}
2526

2627
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/create_queue.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ impl CreateQueueBuilder {
2424
setters! {
2525
metadata: Metadata => Some(metadata),
2626
timeout: Timeout => Some(timeout),
27+
context: Context => context,
2728
}
2829

2930
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/delete_message.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ impl DeleteMessageBuilder {
2121

2222
setters! {
2323
timeout: Timeout => Some(timeout),
24+
context: Context => context,
2425
}
2526

2627
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/delete_queue.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ impl DeleteQueueBuilder {
2121

2222
setters! {
2323
timeout: Timeout => Some(timeout),
24+
context: Context => context,
2425
}
2526

2627
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/get_messages.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ impl GetMessagesBuilder {
2929
number_of_messages: NumberOfMessages => Some(number_of_messages),
3030
visibility_timeout: VisibilityTimeout => Some(visibility_timeout),
3131
timeout: Timeout => Some(timeout),
32+
context: Context => context,
3233
}
3334

3435
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/get_queue_acl.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ impl GetQueueACLBuilder {
2121

2222
setters! {
2323
timeout: Timeout => Some(timeout),
24+
context: Context => context,
2425
}
2526

2627
pub fn into_future(mut self) -> Response {

sdk/storage_queues/src/operations/get_queue_metadata.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ impl GetQueueMetadataBuilder {
2121

2222
setters! {
2323
timeout: Timeout => Some(timeout),
24+
context: Context => context,
2425
}
2526

2627
pub fn into_future(mut self) -> Response {

0 commit comments

Comments
 (0)