Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10694 #41247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10694 See eng/common workflow

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 18:40
@azure-sdk azure-sdk requested a review from a team as a code owner May 21, 2025 18:40
@azure-sdk azure-sdk requested a review from benbp May 21, 2025 18:40
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 21, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with updates from azure‑sdk‑tools, adjusting path resolution in the common PowerShell script.

  • Updates the repository root path resolution in common.ps1 by modifying the relative path.
Comments suppressed due to low confidence (1)

eng/common/scripts/common.ps1:3

  • The new relative path traverses three levels up whereas the previous version traversed four; please verify that this change is intentional to correctly point to the repository root.
$RepoRoot = Resolve-Path "${PSScriptRoot}/../../../"

@azure-sdk azure-sdk force-pushed the sync-eng/common-benbp/fix-common-resolve-10694 branch from b657a67 to f57359c Compare June 2, 2025 23:11
@azure-sdk azure-sdk merged commit 16fb7f3 into main Jun 3, 2025
16 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-benbp/fix-common-resolve-10694 branch June 3, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants