updating tools

Author: l0lawrence

.github/copilot-instructions.md

@@ -13,15 +13,16 @@ When someone asks to run validation on their library, ask them what supported en
 
 Initialize and validate a TypeSpec client library for Azure SDK for Python. Please:
 
-1. If the typespec mcp tool is available use that for generating or initializing. Otherwise please follow the instructions below to generate an SDK from TypeSpec.
+1. If the typespec mcp tool is available use that for generating or initializing. If asked to update changes from local spec repo, lets find the path to that local azure-rest-api-specs repo for our tools. Otherwise please follow the instructions below to generate an SDK from TypeSpec.
    - Ensure that node, python, and the required dependencies are installed in your environment (@azure-tools/typespec-client-generator-cli)
    - If provided a url to a tspconfig.yaml ensure it has the most recent commit hash of the tspconfig.yaml file instead of a branch name like `main`. If the url does not have a commit hash, use the GitHub API to get the most recent commit hash of the tspconfig.yaml file. If you are unable to do this, ask the user to provide the correct url. `curl -s "https://api.github.com/repos/Azure/azure-rest-api-specs/commits?path=,path to tspconfig.yaml>&per_page=1"`  helpful.
    - If prompted to initialize the SDK from a url or a local repo use the command `npx @azure-tools/typespec-client-generator-cli init --tsp-config [URL or local azure-rest-api-specs path to tspconfig.yaml]`. The tsp-client init command runs sync and generate under the hood, so generation is complete after the init concludes. If the tspconfig.yaml value is a path to a local file, you can mention that the user will have to populate the values in tsp-location.yaml themselves.
    - If prompted to update the SDK use the command `npx @azure-tools/typespec-client-generator-cli update`.
    - If prompted to generate the SDK use the command `npx @azure-tools/typespec-client-generator-cli generate`.
    - If prompted to sync the SDK use the command `npx @azure-tools/typespec-client-generator-cli sync`.
    - If prompted to sync with local code use the command `npx @azure-tools/typespec-client-generator-cli sync --local-spec-repo [path to local azure-rest-api-specs repo]`. 
-   - If syncing from a local repo, do not grab a commit hash and do not manually create directories. The command will create the directories for you.
+   - If syncing from a local repo, do not grab a commit hash.
+   - Do not manually create directories. The command will create the directories for you.
    - If asked to sync or generate `package-name` we need to find the path to the package's tsp-location.yaml in the azure-sdk-for-python repo and run the command in the same directory.
 
 2. After generation is complete, validate the output by:
@@ -33,6 +34,13 @@ Initialize and validate a TypeSpec client library for Azure SDK for Python. Plea
 
 3. If any errors or warnings are found, after running all validation checks provide guidance on fixing them following Azure SDK best practices. 
 
+4. After the above steps, let's use the GitHub mcp tool to create a pull request with the changes. The pull request should include:
+   - A title that describes the changes made.
+   - A description that includes the following:
+     - A summary of the changes made.
+     - A list of any issues or warnings found during validation and how they were fixed.
+     - Any additional notes or comments about the changes made.
+
 Please use Python 3.9 for compatibility, and refer to the Azure SDK design guidelines (https://azure.github.io/azure-sdk/python_design.html) for any implementation decisions.
 
 

.vscode/mcp.json

@@ -28,6 +28,20 @@
                 "run",
                 "main.py"
             ]
+        },
+        "github": {
+        "command": "docker",
+        "args": [
+          "run",
+          "-i",
+          "--rm",
+          "-e",
+          "GITHUB_PERSONAL_ACCESS_TOKEN",
+          "ghcr.io/github/github-mcp-server"
+        ],
+        "env": {
+          "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:gh_token}"
         }
-    }   
-}
+      }
+    }
+  }

tools/mcp/typespec-story/main.py

@@ -93,14 +93,21 @@ def run_typespec_cli_command(command: str, args: Dict[str, Any], root_dir: Optio
     try:
         # TODO: maybe if we return and dont wait for output this will work
         # Run the command and capture the output
-        result = subprocess.run(
-            cli_args,
-            capture_output=True,
-            text=True,
-            cwd=root_dir,
-        )
+        if root_dir:
+            result = subprocess.run(
+                cli_args,
+                capture_output=True,
+                text=True,
+                cwd=root_dir,
+            )
+        else:
+            result = subprocess.run(
+                cli_args,
+                capture_output=True,
+                text=True,
+            )
         logger.info(f"Command output: {result.stdout}")
-        
+
         return {
             "success": True,
             "stdout": result.stdout,
@@ -138,8 +145,120 @@ def init_tool(tsp_config_url: str, root_dir: Optional[str] = None) -> Dict[str,
     args = {}
     args["tsp-config"] = updated_url
 
+    # If root_dir is not provided, use the repository root
+    if root_dir is None:
+        root_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
+        logger.info(f"No root_dir provided, using repository root: {root_dir}")
+    
+    return run_typespec_cli_command("init", args, root_dir=root_dir)
+
+@mcp.tool("init_local")
+def init_local_tool(tsp_config_path: str, root_dir: Optional[str] = None) -> Dict[str, Any]:
+    """Initialize a typespec client library directory from a local azure-rest-api-specs repo.
+
+    Args:
+        tsp_config_path: The path to the local tspconfig.yaml file.
+        root_dir: The root directory where the client library will be generated.
+    
+    Returns:
+        A dictionary containing the result of the command.
+    """
+    # Prepare arguments for the CLI command
+    args = {}
+    args["tsp-config"] = tsp_config_path
+    
+    # If root_dir is not provided, use the repository root
+    if root_dir is None:
+        root_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
+        logger.info(f"No root_dir provided, using repository root: {root_dir}")
+    
     return run_typespec_cli_command("init", args, root_dir=root_dir)
 
+@mcp.tool("generate")
+def generate_tool(project_dir: Optional[str] = None) -> Dict[str, Any]:
+    """Generate a typespec client library given the url.
+    
+    Args:
+        project_dir: The directory of the client library to be generated.
+    
+    Returns:
+        A dictionary containing the result of the command.
+    """
+    # Prepare arguments for the CLI command
+    args: Dict[str, Any] = {}
+    
+    # If project_dir is not provided, use the current directory
+    if project_dir is None:
+        logger.info("No project_dir provided, using current directory")
+    
+    return run_typespec_cli_command("generate", args, root_dir=project_dir)
+
+@mcp.tool("update")
+def update_tool(project_dir: Optional[str] = None) -> Dict[str, Any]:
+    """Update a typespec client library.
+    
+    This command looks for a tsp-location.yaml file in the current directory to sync a TypeSpec project
+    and generate a client library. It calls sync and generate commands internally.
+    
+    Args:
+        project_dir: The root directory where the client library will be updated.
+    
+    Returns:
+        A dictionary containing the result of the command.
+    """
+    # Prepare arguments for the CLI command
+    args: Dict[str, Any] = {}
+    
+    # If project_dir is not provided, use the current directory as this command
+    # expects to find tsp-location.yaml in the working directory
+    if project_dir is None:
+        logger.info("No project_dir provided, using current directory")
+    
+    return run_typespec_cli_command("update", args, root_dir=project_dir)
+
+@mcp.tool("sync") 
+def sync_tool(project_dir: Optional[str] = None) -> Dict[str, Any]:
+    """Sync a typespec client library from the remote repository.
+    
+    This command looks for a tsp-location.yaml file to get the project details and sync them to a temporary directory.
+    
+    Args:
+        project_dir: The root directory where the client library will be synced.
+    
+    Returns:
+        A dictionary containing the result of the command.
+    """
+    # Prepare arguments for the CLI command
+    args: Dict[str, Any] = {}
+    
+    # If project_dir is not provided, use the current directory as this command
+    # expects to find tsp-location.yaml in the working directory
+    if project_dir is None:
+        logger.info("No project_dir provided, using current directory")
+    
+    return run_typespec_cli_command("sync", args, root_dir=project_dir)
+
+@mcp.tool("sync_local")
+def sync_local_tool(local_spec_repo: str, project_dir: Optional[str] = None) -> Dict[str, Any]:
+    """Sync a typespec client library from a local repository.
+    
+    Args:
+        local_spec_repo: The path to the local azure-rest-api-specs repository.
+        project_dir: The root directory where the client library will be synced.
+
+    Returns:
+        A dictionary containing the result of the command.
+    """
+    # Prepare arguments for the CLI command
+    args: Dict[str, Any] = {}
+    args["local-spec-repo"] = local_spec_repo
+    
+    # If project_dir is not provided, use the current directory
+    if project_dir is None:
+        logger.info("No project_dir provided, using current directory")
+    
+    return run_typespec_cli_command("sync", args, root_dir=project_dir)
+
 # Run the MCP server
 if __name__ == "__main__":
     # Initialize and run the server

tools/mcp/validation/pyproject.toml

@@ -16,4 +16,5 @@ dependencies = [
     "bandit>=1.7.0",
     "tox<5",
     "httpx>=0.28.1",
+    "azure-core>=1.34.0",
 ]